Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 677063002: Rebaseline crash tests in fast/multicol/span with dumpAsText. (Closed)

Created:
6 years, 2 months ago by andersr
Modified:
6 years, 1 month ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Rebaseline crash tests in fast/multicol/span with dumpAsText. R=mstensho@opera.com BUG=386567 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184475

Patch Set 1 #

Total comments: 6

Patch Set 2 : Add DOCTYPE and "PASS if no crash". #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -487 lines) Patch
M LayoutTests/TestExpectations View 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/fast/multicol/span/anonymous-before-child-parent-crash.html View 1 3 chunks +4 lines, -1 line 0 comments Download
A + LayoutTests/fast/multicol/span/anonymous-before-child-parent-crash-expected.txt View 1 1 chunk +5 lines, -20 lines 0 comments Download
M LayoutTests/fast/multicol/span/anonymous-split-block-crash.html View 1 2 chunks +6 lines, -1 line 0 comments Download
A + LayoutTests/fast/multicol/span/anonymous-split-block-crash-expected.txt View 1 1 chunk +2 lines, -20 lines 0 comments Download
M LayoutTests/fast/multicol/span/clone-anonymous-block-non-inline-child-crash.html View 1 2 chunks +6 lines, -1 line 0 comments Download
A + LayoutTests/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt View 1 1 chunk +4 lines, -20 lines 0 comments Download
M LayoutTests/fast/multicol/span/generated-child-split-flow-crash.html View 1 1 chunk +4 lines, -0 lines 0 comments Download
D LayoutTests/fast/multicol/span/generated-child-split-flow-crash-expected.png View Binary file 0 comments Download
M LayoutTests/fast/multicol/span/generated-child-split-flow-crash-expected.txt View 1 1 chunk +4 lines, -20 lines 0 comments Download
D LayoutTests/platform/android/fast/multicol/span/generated-child-split-flow-crash-expected.txt View 1 chunk +0 lines, -20 lines 0 comments Download
D LayoutTests/platform/linux/fast/multicol/span/anonymous-before-child-parent-crash-expected.png View Binary file 0 comments Download
D LayoutTests/platform/linux/fast/multicol/span/anonymous-before-child-parent-crash-expected.txt View 1 chunk +0 lines, -34 lines 0 comments Download
D LayoutTests/platform/linux/fast/multicol/span/anonymous-split-block-crash-expected.png View Binary file 0 comments Download
D LayoutTests/platform/linux/fast/multicol/span/anonymous-split-block-crash-expected.txt View 1 chunk +0 lines, -27 lines 0 comments Download
D LayoutTests/platform/linux/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.png View Binary file 0 comments Download
D LayoutTests/platform/linux/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt View 1 chunk +0 lines, -33 lines 0 comments Download
D LayoutTests/platform/linux/fast/multicol/span/generated-child-split-flow-crash-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac/fast/multicol/span/anonymous-before-child-parent-crash-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac/fast/multicol/span/anonymous-before-child-parent-crash-expected.txt View 1 chunk +0 lines, -34 lines 0 comments Download
D LayoutTests/platform/mac/fast/multicol/span/anonymous-split-block-crash-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac/fast/multicol/span/anonymous-split-block-crash-expected.txt View 1 chunk +0 lines, -28 lines 0 comments Download
D LayoutTests/platform/mac/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt View 1 chunk +0 lines, -34 lines 0 comments Download
D LayoutTests/platform/win-xp/fast/multicol/span/anonymous-before-child-parent-crash-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win-xp/fast/multicol/span/anonymous-before-child-parent-crash-expected.txt View 1 chunk +0 lines, -34 lines 0 comments Download
D LayoutTests/platform/win-xp/fast/multicol/span/anonymous-split-block-crash-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win-xp/fast/multicol/span/anonymous-split-block-crash-expected.txt View 1 chunk +0 lines, -27 lines 0 comments Download
D LayoutTests/platform/win-xp/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win-xp/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt View 1 chunk +0 lines, -33 lines 0 comments Download
D LayoutTests/platform/win/fast/multicol/span/anonymous-before-child-parent-crash-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/multicol/span/anonymous-before-child-parent-crash-expected.txt View 1 chunk +0 lines, -34 lines 0 comments Download
D LayoutTests/platform/win/fast/multicol/span/anonymous-split-block-crash-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/multicol/span/anonymous-split-block-crash-expected.txt View 1 chunk +0 lines, -28 lines 0 comments Download
D LayoutTests/platform/win/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt View 1 chunk +0 lines, -34 lines 0 comments Download

Messages

Total messages: 12 (3 generated)
andersr
6 years, 2 months ago (2014-10-24 11:07:40 UTC) #1
andersr
Actually, ignore this. I just noticed these are image+text fails, not just text fails. Must ...
6 years, 2 months ago (2014-10-24 11:11:20 UTC) #2
andersr
Actually, ignore this. I just noticed these are image+text fails, not just text fails. Must ...
6 years, 2 months ago (2014-10-24 11:11:21 UTC) #3
andersr
On 2014/10/24 11:11:21, andersr wrote: > Actually, ignore this. I just noticed these are image+text ...
6 years, 2 months ago (2014-10-24 11:58:53 UTC) #4
mstensho (USE GERRIT)
lgtm https://codereview.chromium.org/677063002/diff/1/LayoutTests/fast/multicol/span/anonymous-before-child-parent-crash-expected.txt File LayoutTests/fast/multicol/span/anonymous-before-child-parent-crash-expected.txt (right): https://codereview.chromium.org/677063002/diff/1/LayoutTests/fast/multicol/span/anonymous-before-child-parent-crash-expected.txt#newcode1 LayoutTests/fast/multicol/span/anonymous-before-child-parent-crash-expected.txt:1: PASS Might as well make the test say ...
6 years, 1 month ago (2014-10-24 21:23:54 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/677063002/20001
6 years, 1 month ago (2014-10-27 17:16:26 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/33781)
6 years, 1 month ago (2014-10-27 19:07:15 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/677063002/20001
6 years, 1 month ago (2014-10-27 20:22:55 UTC) #11
commit-bot: I haz the power
6 years, 1 month ago (2014-10-27 21:13:10 UTC) #12
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as 184475

Powered by Google App Engine
This is Rietveld 408576698