Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issue 677033002: [android_webview] Extract common SystemWebview parameters to .gypi file. (Closed)

Created:
6 years, 2 months ago by mkosiba (inactive)
Modified:
6 years, 2 months ago
Reviewers:
Torne
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[android_webview] Extract common SystemWebview parameters to .gypi file. This extracts the common SystemWebview gyp params to a shared .gypi file. BUG=None TEST=compiles Committed: https://crrev.com/c5bdcca1573b6dd37eb828877fff8d136f8c7e7b Cr-Commit-Position: refs/heads/master@{#301100}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -30 lines) Patch
M third_party/android_webview_glue/android_webview_glue.gypi View 1 2 chunks +2 lines, -30 lines 0 comments Download
A third_party/android_webview_glue/android_webview_glue_common.gypi View 1 2 1 chunk +37 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
mkosiba (inactive)
6 years, 2 months ago (2014-10-24 10:28:52 UTC) #3
Torne
lgtm
6 years, 2 months ago (2014-10-24 12:39:52 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/677033002/60001
6 years, 2 months ago (2014-10-24 13:54:32 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:60001)
6 years, 2 months ago (2014-10-24 14:36:44 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-10-24 14:37:44 UTC) #8
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/c5bdcca1573b6dd37eb828877fff8d136f8c7e7b
Cr-Commit-Position: refs/heads/master@{#301100}

Powered by Google App Engine
This is Rietveld 408576698