Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Issue 6770013: One minor build change fix -- missed this in the last upload. ... (Closed)

Created:
9 years, 9 months ago by mmortensen
Modified:
9 years, 7 months ago
Reviewers:
garianov, mlinck
CC:
native-client-reviews_googlegroups.com
Visibility:
Public.

Description

One minor build change fix -- missed this in the last upload. To do this, I pulled a new repo to make sure it would build in a clean repo. With this change, the VSX code built and ran, successfully talking to sel_ldr64.exe (which is no longer built in vsx).

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M experimental/visual_studio_plugin/src/debug_conn/debug_conn.vcproj View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
mmortensen
9 years, 9 months ago (2011-03-29 15:26:22 UTC) #1
mmortensen
Since this is in experimental...and required for the build to work, I landed this as ...
9 years, 9 months ago (2011-03-29 15:27:18 UTC) #2
mlinck
9 years, 9 months ago (2011-03-29 15:45:21 UTC) #3
LGTM

On Tue, Mar 29, 2011 at 9:27 AM, <mmortensen@google.com> wrote:

> Since this is in experimental...and required for the build to work, I
> landed
> this as revision 786.
>
> However, I wanted everyone to be aware of the change in case there were
> suggestions for other ways to do it.
>
> Thx,
> -Mike
>
>
> http://codereview.chromium.org/6770013/
>



-- 
Michael Linck
Software Engineer - Native Client
Boulder Community Grants Team
Google

-- 
You received this message because you are subscribed to the Google Groups
"Native-Client-Reviews" group.
To post to this group, send email to native-client-reviews@googlegroups.com.
To unsubscribe from this group, send email to
native-client-reviews+unsubscribe@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/native-client-reviews?hl=en.

Powered by Google App Engine
This is Rietveld 408576698