Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 676983004: Autofill: Fix recognition of Walmart ZIP code. (Closed)

Created:
6 years, 2 months ago by Evan Stade
Modified:
6 years, 2 months ago
Reviewers:
Ilya Sherman
CC:
chromium-reviews, benquan, browser-components-watch_chromium.org, Dane Wallinga, dyu1, estade+watch_chromium.org, Ilya Sherman, rouslan+autofillwatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Autofill: Fix recognition of Walmart ZIP code. BUG=426958 Committed: https://crrev.com/dbec51e8134df4f722085ef98144ac0cd207eead Cr-Commit-Position: refs/heads/master@{#301252}

Patch Set 1 #

Patch Set 2 : just this patch #

Patch Set 3 : retry upload #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -4 lines) Patch
M chrome/test/data/autofill/heuristics/output/20_checkout_m_walmart.com.out View 1 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/core/browser/address_field.cc View 1 chunk +11 lines, -3 lines 2 comments Download

Messages

Total messages: 9 (2 generated)
Evan Stade
6 years, 2 months ago (2014-10-24 19:45:19 UTC) #2
Ilya Sherman
LGTM, thanks. https://codereview.chromium.org/676983004/diff/40001/components/autofill/core/browser/address_field.cc File components/autofill/core/browser/address_field.cc (right): https://codereview.chromium.org/676983004/diff/40001/components/autofill/core/browser/address_field.cc#newcode200 components/autofill/core/browser/address_field.cc:200: // http://crbug.com/426958 Ouch.
6 years, 2 months ago (2014-10-24 20:28:13 UTC) #3
Evan Stade
https://codereview.chromium.org/676983004/diff/40001/components/autofill/core/browser/address_field.cc File components/autofill/core/browser/address_field.cc (right): https://codereview.chromium.org/676983004/diff/40001/components/autofill/core/browser/address_field.cc#newcode200 components/autofill/core/browser/address_field.cc:200: // http://crbug.com/426958 On 2014/10/24 20:28:13, Ilya Sherman wrote: > ...
6 years, 2 months ago (2014-10-24 20:32:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/676983004/40001
6 years, 2 months ago (2014-10-24 23:12:11 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
6 years, 2 months ago (2014-10-25 00:45:49 UTC) #7
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/dbec51e8134df4f722085ef98144ac0cd207eead Cr-Commit-Position: refs/heads/master@{#301252}
6 years, 2 months ago (2014-10-25 00:46:30 UTC) #8
Avi (use Gerrit)
6 years, 1 month ago (2014-10-25 17:51:14 UTC) #9
Message was sent while issue was closed. 
A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/675303005/ by avi@chromium.org.

The reason for reverting is: The tree exploded with zillions of bots across all
platforms failing FormStructureBrowserTest.DataDrivenHeuristics21.
FormStructureBrowserTest is autofill, and this is the only autofill change
landed around the time everything died..

Powered by Google App Engine
This is Rietveld 408576698