Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(336)

Issue 676953005: Revert of Replace Chrome IPC with Mojo IPC for querying BatteryStatus service (Closed)

Created:
6 years, 1 month ago by leviw_travelin_and_unemployed
Modified:
6 years, 1 month ago
CC:
chromium-reviews, creis+watch_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, nasko+codewatch_chromium.org, timvolodine, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, yzshen+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org, darin (slow to review), ben+mojo_chromium.org, qsr
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Replace Chrome IPC with Mojo IPC for querying BatteryStatus service (patchset #23 id:570001 of https://codereview.chromium.org/592153002/) Reason for revert: Broke battery-status LayoutTests: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=battery-status Original issue's description: > Replace Chrome IPC with Mojo IPC for querying BatteryStatus service > > This is based on patch set 26 from Darin's https://codereview.chromium.org/457933002/ . > > BUG=420623 > > Committed: https://crrev.com/9e6d2387b6d9b28ab6defe7f5feb715a5abbc242 > Cr-Commit-Position: refs/heads/master@{#301380} TBR=rockot@chromium.org,timvolodine@chromium.org,jam@chromium.org,viettrungluu@chromium.org,jln@chromium.org,tsepez@chromium.org,ppi@chromium.org NOTREECHECKS=true NOTRY=true BUG=420623 Committed: https://crrev.com/86b6faceb71f9b67b2797fc4782cba4a04855d78 Cr-Commit-Position: refs/heads/master@{#301402}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2485 lines, -2730 lines) Patch
M BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M content/app/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M content/app/android/library_loader_hooks.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M content/browser/BUILD.gn View 3 chunks +14 lines, -7 lines 0 comments Download
M content/browser/DEPS View 2 chunks +1 line, -1 line 0 comments Download
M content/browser/android/browser_jni_registrar.cc View 2 chunks +2 lines, -0 lines 0 comments Download
A content/browser/battery_status/OWNERS View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/battery_status/battery_status_browsertest.cc View 9 chunks +29 lines, -31 lines 0 comments Download
A content/browser/battery_status/battery_status_manager.h View 1 chunk +36 lines, -0 lines 0 comments Download
A content/browser/battery_status/battery_status_manager_android.h View 1 chunk +45 lines, -0 lines 0 comments Download
A content/browser/battery_status/battery_status_manager_android.cc View 1 chunk +65 lines, -0 lines 0 comments Download
A content/browser/battery_status/battery_status_manager_chromeos.cc View 1 chunk +184 lines, -0 lines 0 comments Download
A content/browser/battery_status/battery_status_manager_default.cc View 1 chunk +40 lines, -0 lines 0 comments Download
A content/browser/battery_status/battery_status_manager_linux.h View 1 chunk +34 lines, -0 lines 0 comments Download
A content/browser/battery_status/battery_status_manager_linux.cc View 1 chunk +383 lines, -0 lines 0 comments Download
A content/browser/battery_status/battery_status_manager_linux_unittest.cc View 1 chunk +143 lines, -0 lines 0 comments Download
A content/browser/battery_status/battery_status_manager_mac.cc View 1 chunk +286 lines, -0 lines 0 comments Download
A content/browser/battery_status/battery_status_manager_win.h View 1 chunk +26 lines, -0 lines 0 comments Download
A content/browser/battery_status/battery_status_manager_win.cc View 1 chunk +239 lines, -0 lines 0 comments Download
A content/browser/battery_status/battery_status_manager_win_unittest.cc View 1 chunk +80 lines, -0 lines 0 comments Download
A content/browser/battery_status/battery_status_message_filter.cc View 1 chunk +56 lines, -0 lines 0 comments Download
A content/browser/battery_status/battery_status_service.h View 1 chunk +66 lines, -0 lines 0 comments Download
A content/browser/battery_status/battery_status_service.cc View 1 chunk +106 lines, -0 lines 0 comments Download
A content/browser/battery_status/battery_status_service_unittest.cc View 1 chunk +189 lines, -0 lines 0 comments Download
M content/browser/browser_main_loop.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.h View 1 chunk +0 lines, -3 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 5 chunks +3 lines, -7 lines 0 comments Download
A content/common/battery_status_messages.h View 1 chunk +32 lines, -0 lines 0 comments Download
M content/common/content_message_generator.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/content.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M content/content_browser.gypi View 7 chunks +21 lines, -2 lines 0 comments Download
M content/content_common.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M content/content_jni.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M content/content_renderer.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M content/content_tests.gypi View 6 chunks +6 lines, -3 lines 0 comments Download
A content/public/android/java/src/org/chromium/content/browser/BatteryStatusManager.java View 1 chunk +148 lines, -0 lines 0 comments Download
A content/public/android/javatests/src/org/chromium/content/browser/BatteryStatusManagerTest.java View 1 chunk +166 lines, -0 lines 0 comments Download
M content/renderer/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/battery_status/battery_status_dispatcher.h View 1 chunk +16 lines, -13 lines 0 comments Download
M content/renderer/battery_status/battery_status_dispatcher.cc View 1 chunk +32 lines, -19 lines 0 comments Download
M content/renderer/renderer_blink_platform_impl.cc View 3 chunks +26 lines, -32 lines 0 comments Download
M content/renderer/shared_memory_seqlock_reader.h View 2 chunks +2 lines, -1 line 0 comments Download
M content/renderer/shared_memory_seqlock_reader.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M content/test/data/battery_status/battery_status_default_test.html View 1 chunk +1 line, -1 line 0 comments Download
M content/test/data/battery_status/battery_status_promise_resolution_test.html View 1 chunk +1 line, -1 line 0 comments Download
D device/battery/BUILD.gn View 1 chunk +0 lines, -103 lines 0 comments Download
D device/battery/DEPS View 1 chunk +0 lines, -4 lines 0 comments Download
D device/battery/OWNERS View 1 chunk +0 lines, -4 lines 0 comments Download
D device/battery/android/BUILD.gn View 1 chunk +0 lines, -13 lines 0 comments Download
D device/battery/android/battery_jni_registrar.h View 1 chunk +0 lines, -20 lines 0 comments Download
D device/battery/android/battery_jni_registrar.cc View 1 chunk +0 lines, -27 lines 0 comments Download
D device/battery/android/java/src/org/chromium/device/battery/BatteryStatusManager.java View 1 chunk +0 lines, -148 lines 0 comments Download
D device/battery/android/javatests/src/org/chromium/device/battery/BatteryStatusManagerTest.java View 1 chunk +0 lines, -166 lines 0 comments Download
D device/battery/battery.gyp View 1 chunk +0 lines, -141 lines 0 comments Download
D device/battery/battery_export.h View 1 chunk +0 lines, -29 lines 0 comments Download
D device/battery/battery_monitor.mojom View 1 chunk +0 lines, -18 lines 0 comments Download
D device/battery/battery_monitor_impl.h View 1 chunk +0 lines, -34 lines 0 comments Download
D device/battery/battery_monitor_impl.cc View 1 chunk +0 lines, -34 lines 0 comments Download
D device/battery/battery_status.mojom View 1 chunk +0 lines, -14 lines 0 comments Download
D device/battery/battery_status_manager.h View 1 chunk +0 lines, -35 lines 0 comments Download
D device/battery/battery_status_manager_android.h View 1 chunk +0 lines, -45 lines 0 comments Download
D device/battery/battery_status_manager_android.cc View 1 chunk +0 lines, -65 lines 0 comments Download
D device/battery/battery_status_manager_chromeos.cc View 1 chunk +0 lines, -156 lines 0 comments Download
D device/battery/battery_status_manager_default.cc View 1 chunk +0 lines, -40 lines 0 comments Download
D device/battery/battery_status_manager_linux.h View 1 chunk +0 lines, -34 lines 0 comments Download
D device/battery/battery_status_manager_linux.cc View 1 chunk +0 lines, -373 lines 0 comments Download
D device/battery/battery_status_manager_linux_unittest.cc View 1 chunk +0 lines, -143 lines 0 comments Download
D device/battery/battery_status_manager_mac.cc View 1 chunk +0 lines, -243 lines 0 comments Download
D device/battery/battery_status_manager_win.h View 1 chunk +0 lines, -26 lines 0 comments Download
D device/battery/battery_status_manager_win.cc View 1 chunk +0 lines, -212 lines 0 comments Download
D device/battery/battery_status_manager_win_unittest.cc View 1 chunk +0 lines, -80 lines 0 comments Download
D device/battery/battery_status_service.h View 1 chunk +0 lines, -71 lines 0 comments Download
D device/battery/battery_status_service.cc View 1 chunk +0 lines, -106 lines 0 comments Download
D device/battery/battery_status_service_unittest.cc View 1 chunk +0 lines, -194 lines 0 comments Download
M device/device_tests.gyp View 4 chunks +1 line, -15 lines 0 comments Download
M mojo/common/handle_watcher.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
leviw_travelin_and_unemployed
Created Revert of Replace Chrome IPC with Mojo IPC for querying BatteryStatus service
6 years, 1 month ago (2014-10-27 18:50:42 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/676953005/1
6 years, 1 month ago (2014-10-27 18:53:27 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-10-27 18:56:43 UTC) #3
commit-bot: I haz the power
6 years, 1 month ago (2014-10-27 18:57:33 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/86b6faceb71f9b67b2797fc4782cba4a04855d78
Cr-Commit-Position: refs/heads/master@{#301402}

Powered by Google App Engine
This is Rietveld 408576698