Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(909)

Unified Diff: cc/trees/layer_tree_host_unittest_picture.cc

Issue 676953003: cc: Always keep the PictureLayerImpl::twin_layer_ pointer valid. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: twins: anothercheck Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/trees/layer_tree_host_impl_unittest.cc ('k') | cc/trees/layer_tree_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/trees/layer_tree_host_unittest_picture.cc
diff --git a/cc/trees/layer_tree_host_unittest_picture.cc b/cc/trees/layer_tree_host_unittest_picture.cc
index b81fdff93e52f1d6e3edd60d0da59ae09f08bee6..2d485b40f50c54de6d34f3a9c1df2ec67865d314 100644
--- a/cc/trees/layer_tree_host_unittest_picture.cc
+++ b/cc/trees/layer_tree_host_unittest_picture.cc
@@ -66,13 +66,13 @@ class LayerTreeHostPictureTestTwinLayer
if (!active_root_impl) {
EXPECT_EQ(0, activates_);
- EXPECT_EQ(NULL, pending_picture_impl->twin_layer());
+ EXPECT_EQ(nullptr, pending_picture_impl->GetPendingOrActiveTwinLayer());
return;
}
if (active_root_impl->children().empty()) {
EXPECT_EQ(3, activates_);
- EXPECT_EQ(NULL, pending_picture_impl->twin_layer());
+ EXPECT_EQ(nullptr, pending_picture_impl->GetPendingOrActiveTwinLayer());
return;
}
@@ -84,20 +84,28 @@ class LayerTreeHostPictureTestTwinLayer
// and the next commit will have a pending and active twin again.
EXPECT_TRUE(activates_ == 1 || activates_ == 4);
- EXPECT_EQ(pending_picture_impl, active_picture_impl->twin_layer());
- EXPECT_EQ(active_picture_impl, pending_picture_impl->twin_layer());
+ EXPECT_EQ(pending_picture_impl,
+ active_picture_impl->GetPendingOrActiveTwinLayer());
+ EXPECT_EQ(active_picture_impl,
+ pending_picture_impl->GetPendingOrActiveTwinLayer());
+ EXPECT_EQ(nullptr, active_picture_impl->GetRecycledTwinLayer());
}
void DidActivateTreeOnThread(LayerTreeHostImpl* impl) override {
LayerImpl* active_root_impl = impl->active_tree()->root_layer();
+ LayerImpl* recycle_root_impl = impl->recycle_tree()->root_layer();
if (active_root_impl->children().empty()) {
EXPECT_EQ(2, activates_);
} else {
FakePictureLayerImpl* active_picture_impl =
static_cast<FakePictureLayerImpl*>(active_root_impl->children()[0]);
+ FakePictureLayerImpl* recycle_picture_impl =
+ static_cast<FakePictureLayerImpl*>(recycle_root_impl->children()[0]);
- EXPECT_EQ(NULL, active_picture_impl->twin_layer());
+ EXPECT_EQ(nullptr, active_picture_impl->GetPendingOrActiveTwinLayer());
+ EXPECT_EQ(recycle_picture_impl,
+ active_picture_impl->GetRecycledTwinLayer());
}
++activates_;
« no previous file with comments | « cc/trees/layer_tree_host_impl_unittest.cc ('k') | cc/trees/layer_tree_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698