chrome/browser/autocomplete/search_provider.h - Issue 67693004: Omnibox: Don't Let Users Escape Keyword Mode Accidentally

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/autocomplete/search_provider.h

Issue 67693004: Omnibox: Don't Let Users Escape Keyword Mode Accidentally (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: new approach Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/autocomplete/search_provider.h

diff --git a/chrome/browser/autocomplete/search_provider.h b/chrome/browser/autocomplete/search_provider.h

index 9b63da08e3a272b5da17be58024c1696f08b85f3..c3a70ea64690725a3806af7f3a772ef7dca933a7 100644

--- a/chrome/browser/autocomplete/search_provider.h

+++ b/chrome/browser/autocomplete/search_provider.h

@@ -428,7 +428,9 @@ class SearchProvider : public AutocompleteProvider,

// Checks if suggested relevances violate certain expected constraints.

// See UpdateMatches() for the use and explanation of these constraints.

- bool IsTopMatchNavigationInKeywordMode(

+ bool IsTopMatchNavigation(

+ bool autocomplete_result_will_reorder_for_default_match) const;

+ bool HasKeywordMatchThatCanBeDefault(

bool autocomplete_result_will_reorder_for_default_match) const;

bool IsTopMatchScoreTooLow(

bool autocomplete_result_will_reorder_for_default_match) const;