kiosk: Support update url for enterprise.

kiosk: Support update url for enterprise.

- Bring back kiosk update url in device local account policy;
- Use the update url from policy to initialize kiosk cache;

BUG=345123
TEST=KioskEnterpriseTest.PrivateStore

Committed: https://crrev.com/3642e122b21885ef467761b7ee37815c0d98b740
Cr-Commit-Position: refs/heads/master@{#301437}

[xiyuan, 2014-10-23 22:49:11]

xiyuan@chromium.org changed reviewers:
+ jennyz@chromium.org, mnissler@chromium.org

[xiyuan, 2014-10-23 22:49:11]

Mattias, could you or someone from your team could help to review policy/* and
settings/* changes? I am not sure whether I am supposed to just revive a
deprecated field like that. Let me know if that is okay.

Jenny, please review everything else.

Thanks.

[Mattias Nissler (ping if slow), 2014-10-24 09:10:36]

mnissler@chromium.org changed reviewers:
+ binzhao@chromium.org

[Mattias Nissler (ping if slow), 2014-10-24 09:10:38]

Bin: see inline question.

Xiyuan: Please also add decoding to device_policy_decoder_chromeos.cc, so the
new field shows up in chrome://policy as well.

https://codereview.chromium.org/676913002/diff/1/chrome/browser/chromeos/app_...
File chrome/browser/chromeos/app_mode/fake_cws.h (right):

https://codereview.chromium.org/676913002/diff/1/chrome/browser/chromeos/app_...
chrome/browser/chromeos/app_mode/fake_cws.h:36: void
OverrideGallaryCommandlineSwitches();
*Gallery

https://codereview.chromium.org/676913002/diff/1/chrome/browser/chromeos/app_...
chrome/browser/chromeos/app_mode/fake_cws.h:37: // Sets up
|update_check_content_| used in update request response later by
nit: Blank line before comment

https://codereview.chromium.org/676913002/diff/1/chrome/browser/chromeos/app_...
chrome/browser/chromeos/app_mode/fake_cws.h:46: // Request handler for kiosk app
update server.
ditto

https://codereview.chromium.org/676913002/diff/1/chrome/browser/chromeos/poli...
File chrome/browser/chromeos/policy/proto/chrome_device_policy.proto (right):

https://codereview.chromium.org/676913002/diff/1/chrome/browser/chromeos/poli...
chrome/browser/chromeos/policy/proto/chrome_device_policy.proto:269: optional
string update_url = 2;
Bin: IIRC, this never got used on the server, so it should be fine to revive the
field. WDYT?

[chromium-reviews, 2014-10-25 00:22:20]

Right, it seems we never launched the update_url and all the values are
empty in D3. So we should be fine reviving it.

select dthree_customer_info.customer_id from dasher_d3.settings.latest
 where
IS_EXPLICITLY_DEFINED(chrome_device_settings_proto.device_local_accounts.account.kiosk_app.OBSOLETE_update_url);
0 rows in result set (5.86 sec)


On Fri, Oct 24, 2014 at 2:10 AM, <mnissler@chromium.org> wrote:

> Bin: see inline question.
>
> Xiyuan: Please also add decoding to device_policy_decoder_chromeos.cc, so
> the
> new field shows up in chrome://policy as well.
>
>
> https://codereview.chromium.org/676913002/diff/1/chrome/
> browser/chromeos/app_mode/fake_cws.h
> File chrome/browser/chromeos/app_mode/fake_cws.h (right):
>
> https://codereview.chromium.org/676913002/diff/1/chrome/
> browser/chromeos/app_mode/fake_cws.h#newcode36
> chrome/browser/chromeos/app_mode/fake_cws.h:36: void
> OverrideGallaryCommandlineSwitches();
> *Gallery
>
> https://codereview.chromium.org/676913002/diff/1/chrome/
> browser/chromeos/app_mode/fake_cws.h#newcode37
> chrome/browser/chromeos/app_mode/fake_cws.h:37: // Sets up
> |update_check_content_| used in update request response later by
> nit: Blank line before comment
>
> https://codereview.chromium.org/676913002/diff/1/chrome/
> browser/chromeos/app_mode/fake_cws.h#newcode46
> chrome/browser/chromeos/app_mode/fake_cws.h:46: // Request handler for
> kiosk app update server.
> ditto
>
> https://codereview.chromium.org/676913002/diff/1/chrome/
> browser/chromeos/policy/proto/chrome_device_policy.proto
> File chrome/browser/chromeos/policy/proto/chrome_device_policy.proto
> (right):
>
> https://codereview.chromium.org/676913002/diff/1/chrome/
> browser/chromeos/policy/proto/chrome_device_policy.proto#newcode269
> chrome/browser/chromeos/policy/proto/chrome_device_policy.proto:269:
> optional string update_url = 2;
> Bin: IIRC, this never got used on the server, so it should be fine to
> revive the field. WDYT?
>
> https://codereview.chromium.org/676913002/
>



-- 
regards,
Bin

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[xiyuan, 2014-10-25 17:45:26]

device_policy_decoder_chromeos.cc updated too. Hope I did it right. :)

PTAL. Thanks.

https://codereview.chromium.org/676913002/diff/1/chrome/browser/chromeos/app_...
File chrome/browser/chromeos/app_mode/fake_cws.h (right):

https://codereview.chromium.org/676913002/diff/1/chrome/browser/chromeos/app_...
chrome/browser/chromeos/app_mode/fake_cws.h:36: void
OverrideGallaryCommandlineSwitches();
On 2014/10/24 09:10:37, Mattias Nissler wrote:
> *Gallery

Done.

https://codereview.chromium.org/676913002/diff/1/chrome/browser/chromeos/app_...
chrome/browser/chromeos/app_mode/fake_cws.h:37: // Sets up
|update_check_content_| used in update request response later by
On 2014/10/24 09:10:37, Mattias Nissler wrote:
> nit: Blank line before comment

Done.

https://codereview.chromium.org/676913002/diff/1/chrome/browser/chromeos/app_...
chrome/browser/chromeos/app_mode/fake_cws.h:46: // Request handler for kiosk app
update server.
On 2014/10/24 09:10:37, Mattias Nissler wrote:
> ditto

Done.

[Mattias Nissler (ping if slow), 2014-10-27 07:48:25]

LGTM, thanks!

[jennyz, 2014-10-27 18:54:17]

lgtm

[xiyuan, 2014-10-27 19:26:34]

xiyuan@chromium.org changed reviewers:
+ zelidrag@chromium.org

[xiyuan, 2014-10-27 19:26:34]

zel, could I get an owner stamp for
    chromeos/settings/cros_settings_names.h|cc ?

Thanks.

[zel, 2014-10-27 19:55:28]

lgtm

[xiyuan, 2014-10-27 19:55:58]

The CQ bit was checked by xiyuan@chromium.org

[commit-bot: I haz the power, 2014-10-27 19:57:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/676913002/40001

[commit-bot: I haz the power, 2014-10-27 20:53:03]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2014-10-27 20:53:49]

Patchset 3 (id:??) landed as
https://crrev.com/3642e122b21885ef467761b7ee37815c0d98b740
Cr-Commit-Position: refs/heads/master@{#301437}