Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(342)

Issue 676893002: Disabling testConformance in response to test failure (Closed)

Created:
6 years, 2 months ago by qyearsley
Modified:
6 years, 2 months ago
Reviewers:
jamesr
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M mojo/android/javatests/src/org/chromium/mojo/bindings/ValidationTest.java View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
qyearsley
6 years, 2 months ago (2014-10-23 20:55:43 UTC) #1
jamesr
lgtm
6 years, 2 months ago (2014-10-23 20:57:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/676893002/1
6 years, 2 months ago (2014-10-23 20:59:42 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/ed4f7a78af68cd8dcfea63c899fbaf3dd27716e6 Cr-Commit-Position: refs/heads/master@{#300947}
6 years, 2 months ago (2014-10-23 21:06:27 UTC) #6
qyearsley
Committed patchset #1 (id:1) manually as ed4f7a78af68cd8dcfea63c899fbaf3dd27716e6 (presubmit successful).
6 years, 2 months ago (2014-10-23 21:06:31 UTC) #7
Avi (use Gerrit)
6 years, 2 months ago (2014-10-23 21:15:17 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/654543003/ by avi@chromium.org.

The reason for reverting is: Build failure.

http://build.chromium.org/p/chromium.linux/builders/Android%20Clang%20Builder...

../mojo/android/javatests/src/org/chromium/mojo/bindings/ValidationTest.java:181:error:
cannot find symbol
    @DisabledTest
     ^
.

Powered by Google App Engine
This is Rietveld 408576698