Intercept file Open/Close

base/files/protect_file_posix.gypi

Index: base/files/protect_file_posix.gypi
diff --git a/base/files/protect_file_posix.gypi b/base/files/protect_file_posix.gypi
new file mode 100644
index 0000000000000000000000000000000000000000..76a2d7ec339675d3813517a172e455af44cbb55a
--- /dev/null
+++ b/base/files/protect_file_posix.gypi
@@ -0,0 +1,33 @@
+# Copyright 2014 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+# Provides sanity-checks and early crashes on some improper use of posix file
+# descriptors. See protect_file_posix.cc for details.
+#
+# Usage:
+#   {
+#     'target_name': 'libsomething',
+#     'type': 'shared_library',  // Do *not* use it for static libraries.
+#     'includes': [
+#       'base/files/protect_file_posix.gypi'
+#     ],
+#     ...
+#   }
+#
+# TODO(pasko): GN.
+{
+   'conditions': [
+     # In the component build the interceptors have to be declared with
+     # non-hidden visibility, which is not desirable for the release build.
+     # Disable the extra checks for the component build for simplicity.
+     ['component != "shared_library"', {

[Fabrice (no longer in Chrome), 2014/11/04 15:37:21]

Maybe you need to add a test for Windows here if you're going to use that gypi
elsewhere?

[pasko, 2014/11/04 17:48:06]

I am hoping that my scary comments would prevent people from using this on
Windows :)

Yeah, conditioning on Windows here might be useful for target_name=='chrome', on
the other hand we could conditionalize the include itself. Not sure which is
more great, let's just have less code here for now until we care about
target_name=='chrome'.

Currently I care only about android and libchrome DSO, of course.

+       'ldflags': [
+         '-Wl,--wrap=close',
+       ],
+       'dependencies': [
+         '<(DEPTH)/base/base.gyp:protect_file_posix',
+       ],
+     }],
+   ],
+}