Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 676873003: Unexpose getPropertyCSSValue, CSSValue and friends (Closed)

Created:
6 years, 1 month ago by Timothy Loh
Modified:
6 years, 1 month ago
Reviewers:
pdr., eseidel
CC:
darktears, apavlov+blink_chromium.org, arv+blink, blink-reviews, blink-reviews-css, Inactive, dglazkov+blink, ed+blinkwatch_opera.com, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@devtoolsgpcv
Project:
blink
Visibility:
Public.

Description

Unexpose getPropertyCSSValue, CSSValue and friends Intent to remove: https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/3VmxWFzcyJc/GFOnJxnWBN0J This patch unexposes the following by putting them behind a runtime flag: - CSSStyleDeclaration.getPropertyCSSValue - CSSValue - CSSValueList - CSSPrimitiveValue - Counter - RGBColor - Rect - WebKitCSSFilterValue - WebKitCSSTransformValue Since a large number of tests still depend on these features, I'll need to rewrite or delete them before we can actually remove the idl files. BUG=331608 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184766

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -17 lines) Patch
M LayoutTests/virtual/stable/webexposed/global-constructors-listing-expected.txt View 4 chunks +0 lines, -8 lines 0 comments Download
M LayoutTests/webexposed/internal-properties-should-not-be-exposed.html View 1 chunk +2 lines, -2 lines 1 comment Download
M LayoutTests/webexposed/internal-properties-should-not-be-exposed-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/css/CSSPrimitiveValue.idl View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/css/CSSStyleDeclaration.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSValue.idl View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/css/CSSValueList.idl View 1 chunk +3 lines, -1 line 0 comments Download
M Source/core/css/Counter.idl View 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/css/RGBColor.idl View 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/css/Rect.idl View 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/css/WebKitCSSFilterValue.idl View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/css/WebKitCSSTransformValue.idl View 1 chunk +1 line, -0 lines 0 comments Download
M Source/platform/RuntimeEnabledFeatures.in View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Timothy Loh
https://codereview.chromium.org/676873003/diff/1/LayoutTests/webexposed/internal-properties-should-not-be-exposed.html File LayoutTests/webexposed/internal-properties-should-not-be-exposed.html (right): https://codereview.chromium.org/676873003/diff/1/LayoutTests/webexposed/internal-properties-should-not-be-exposed.html#newcode11 LayoutTests/webexposed/internal-properties-should-not-be-exposed.html:11: var internalProperties = { "-internal-marquee-direction": "alternate" }; ..actually this ...
6 years, 1 month ago (2014-10-30 22:28:41 UTC) #3
pdr.
LGTM, thanks for doing this!
6 years, 1 month ago (2014-11-01 03:52:45 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/676873003/1
6 years, 1 month ago (2014-11-01 03:53:33 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-11-01 03:55:18 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 184766

Powered by Google App Engine
This is Rietveld 408576698