Issue 676863002: Use no-op statistics collecting object for WebView.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 676863002: Use no-op statistics collecting object for WebView. (Closed)

Created:
6 years, 2 months ago by hush (inactive)

Modified:
6 years, 2 months ago

Reviewers:

CC:
chromium-reviews, android-webview-reviews_chromium.org, benm (inactive), sgurun-gerrit only

Base URL:
https://chromium.googlesource.com/chromium/src.git@2171

Project:
chromium

Visibility:
Public.

More Reviews

Description

Use no-op statistics collecting object for WebView. WebView does not gather data_reduction_proxy related statistics at the moment. WebView's statistics object writes the data to pref service which does not upload the data to anywhere. BUG=426140 Review URL: https://codereview.chromium.org/651443005 Cr-Commit-Position: refs/heads/master@{#300613} (cherry picked from commit 4441cc1d6e7ac564a885ad425b2e8914977438d7) Conflicts: android_webview/browser/aw_browser_context.cc Committed: https://chromium.googlesource.com/chromium/src/+/736bffdd79634e7db77e2dc385527bd1876f6abf

Patch Set 1 #

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -0 lines)			Patch
	M	android_webview/browser/aw_browser_context.h	View		3 chunks	+4 lines, -0 lines	0 comments	Download
	M	android_webview/browser/aw_browser_context.cc	View		3 chunks	+20 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

hush (inactive)

The conflicts are caused by data reduction proxy being moved under core/ directory in chromium ...

6 years, 2 months ago (2014-10-23 19:28:27 UTC) #1

hush (inactive)

6 years, 2 months ago (2014-10-23 19:31:37 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
736bffdd79634e7db77e2dc385527bd1876f6abf.

Expand Messages | Collapse Messages