Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(543)

Issue 67683004: Add some unit tests for mojo's Buffer classes. (Closed)

Created:
7 years, 1 month ago by Matt Perry
Modified:
7 years, 1 month ago
Reviewers:
DaveMoore
CC:
chromium-reviews, Aaron Boodman, darin (slow to review), viettrungluu+watch_chromium.org, ben+mojo_chromium.org, abarth-chromium
Visibility:
Public.

Description

Add some unit tests for mojo's Buffer classes. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=236158

Patch Set 1 #

Patch Set 2 : edit todo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -1 line) Patch
M mojo/mojo.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/public/bindings/lib/TODO View 1 1 chunk +0 lines, -1 line 0 comments Download
A mojo/public/tests/buffer_unittest.cc View 1 chunk +87 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Matt Perry
Starting to dabble with the codebase. Let me know if these tests make sense or ...
7 years, 1 month ago (2013-11-19 00:31:59 UTC) #1
DaveMoore
lgtm
7 years, 1 month ago (2013-11-19 23:22:39 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mpcomplete@chromium.org/67683004/30001
7 years, 1 month ago (2013-11-19 23:45:42 UTC) #3
commit-bot: I haz the power
7 years, 1 month ago (2013-11-20 05:04:59 UTC) #4
Message was sent while issue was closed.
Change committed as 236158

Powered by Google App Engine
This is Rietveld 408576698