chrome/browser/feedback/feedback_util.h - Issue 67683003: Remove TraceController

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/feedback/feedback_util.h

Issue 67683003: Remove TraceController (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef CHROME_BROWSER_FEEDBACK_FEEDBACK_UTIL_H_	5 #ifndef CHROME_BROWSER_FEEDBACK_FEEDBACK_UTIL_H_

6 #define CHROME_BROWSER_FEEDBACK_FEEDBACK_UTIL_H_	6 #define CHROME_BROWSER_FEEDBACK_FEEDBACK_UTIL_H_

7	7

8 #include <string>	8 #include <string>

9	9

10 #include "base/basictypes.h"	10 #include "base/basictypes.h"

(...skipping 20 matching lines...) Expand all Loading...
31	31

32 namespace chrome {	32 namespace chrome {

33 extern const char kAppLauncherCategoryTag[];	33 extern const char kAppLauncherCategoryTag[];

34 } // namespace chrome	34 } // namespace chrome

35	35

36 namespace feedback_util {	36 namespace feedback_util {

37	37

38 void SendReport(scoped_refptr<FeedbackData> data);	38 void SendReport(scoped_refptr<FeedbackData> data);

39 bool ZipString(const base::FilePath& filename,	39 bool ZipString(const base::FilePath& filename,

40 const std::string& data, std::string* compressed_data);	40 const std::string& data, std::string* compressed_data);

	41 bool ZipFile(const base::FilePath& filename, std::string* compressed_data);
	Zachary Kuznia 2013/11/15 23:21:36 You should put a comment noting that the file will You should put a comment noting that the file will be deleted after the data is compressed. Xianzhu 2013/11/15 23:25:33 ZipFile deletes only the temporary zip file which Show quoted text On 2013/11/15 23:21:36, Zachary Kuznia wrote: > You should put a comment noting that the file will be deleted after the data is > compressed. ZipFile deletes only the temporary zip file which is created by the function and not exposed by the function, not the input file.
41	42

42 } // namespace feedback_util	43 } // namespace feedback_util

43	44

44 #endif // CHROME_BROWSER_FEEDBACK_FEEDBACK_UTIL_H_	45 #endif // CHROME_BROWSER_FEEDBACK_FEEDBACK_UTIL_H_

OLD	NEW

« no previous file with comments | « chrome/browser/automation/automation_provider.cc ('k') | chrome/browser/feedback/feedback_util.cc » ('j') | chrome/browser/feedback/tracing_manager.cc » ('J')