Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 676803002: add float equivalent in dumpHex output as comment (Closed)

Created:
6 years, 2 months ago by caryclark
Modified:
6 years, 2 months ago
Reviewers:
bsalomon, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : adjust path test to match additional output #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -3 lines) Patch
M src/core/SkPath.cpp View 1 chunk +15 lines, -1 line 0 comments Download
M tests/PathTest.cpp View 1 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
caryclark
6 years, 2 months ago (2014-10-23 16:53:01 UTC) #1
bsalomon
lgtm
6 years, 2 months ago (2014-10-23 17:10:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/676803002/1
6 years, 2 months ago (2014-10-23 17:33:05 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: Test-Ubuntu13.10-GCE-NoGPU-x86_64-Release-Shared-Trybot on client.skia (http://build.chromium.org/p/client.skia/builders/Test-Ubuntu13.10-GCE-NoGPU-x86_64-Release-Shared-Trybot/builds/191)
6 years, 2 months ago (2014-10-23 17:39:41 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/676803002/20001
6 years, 2 months ago (2014-10-23 19:27:45 UTC) #8
commit-bot: I haz the power
6 years, 2 months ago (2014-10-23 20:09:03 UTC) #9
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as 08fa28cd31c96b4ebd9cb532539c3a8c88803d90

Powered by Google App Engine
This is Rietveld 408576698