Adding /analyze support to common.gypi through GYP_DEFINES=win_analyze=1

build/common.gypi

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 # IMPORTANT:
 # Please don't directly include this file if you are building via gyp_chromium,
 # since gyp_chromium is automatically forcing its inclusion.
 {
   # Variables expected to be overriden on the GYP command line (-D) or by
   # ~/.gyp/include.gypi.
@@ skipping 328 matching lines @@
       'use_libjpeg_turbo%': 1,
 
       # Use system libjpeg. Note that the system's libjepg will be used even if
       # use_libjpeg_turbo is set.
       'use_system_libjpeg%': 0,
 
       # By default, component is set to static_library and it can be overriden
       # by the GYP command line or by ~/.gyp/include.gypi.
       'component%': 'static_library',
 
+      # /analyze is off by default on Windows because it is very slow and noisy.
+      # Enable with GYP_DEFINES=win_analyze=1
+      'win_analyze%': 0,
+
       # Set to select the Title Case versions of strings in GRD files.
       'use_titlecase_in_grd%': 0,
 
       # Use translations provided by volunteers at launchpad.net.  This
       # currently only works on Linux.
       'use_third_party_translations%': 0,
 
       # Remoting compilation is enabled by default. Set to 0 to disable.
       'remoting%': 1,
 
@@ skipping 742 matching lines @@
     'win_z7%': '<(win_z7)',
     'dcheck_always_on%': '<(dcheck_always_on)',
     'tracing_like_official_build%': '<(tracing_like_official_build)',
     'arm_version%': '<(arm_version)',
     'arm_neon%': '<(arm_neon)',
     'arm_neon_optional%': '<(arm_neon_optional)',
     'sysroot%': '<(sysroot)',
     'chroot_cmd%': '<(chroot_cmd)',
     'system_libdir%': '<(system_libdir)',
     'component%': '<(component)',
+    'win_analyze%': '<(win_analyze)',
     'enable_resource_whitelist_generation%': '<(enable_resource_whitelist_generation)',
     'use_titlecase_in_grd%': '<(use_titlecase_in_grd)',
     'use_third_party_translations%': '<(use_third_party_translations)',
     'remoting%': '<(remoting)',
     'enable_one_click_signin%': '<(enable_one_click_signin)',
     'enable_pre_sync_backup%': '<(enable_pre_sync_backup)',
     'enable_webrtc%': '<(enable_webrtc)',
     'chromium_win_pch%': '<(chromium_win_pch)',
     'configuration_policy%': '<(configuration_policy)',
     'safe_browsing%': '<(safe_browsing)',
@@ skipping 1658 matching lines @@
         ],
       }],
       ['OS=="win"', {
         'defines': [
           '__STD_C',
           '_CRT_SECURE_NO_DEPRECATE',
           '_SCL_SECURE_NO_DEPRECATE',
           # This define is required to pull in the new Win8 interfaces from
           # system headers like ShObjIdl.h.
           'NTDDI_VERSION=0x06020000',
-          # This is required for ATL to use XP-safe versions of its functions.
-          '_USING_V110_SDK71_',
         ],
         'include_dirs': [
           '<(DEPTH)/third_party/wtl/include',
         ],
         'conditions': [
+          ['win_analyze==0', {

[scottmg, 2014/10/27 17:47:02]

i think it would be better to do

'win_analyze':
  'defines!':
    '_USING...'

which removes the define, rather than not adding it, and then it can live near
the other block.

+          # This is required for ATL to use XP-safe versions of its functions.
+          # However it is prohibited when running /analyze.
+            'defines': [
+              '_USING_V110_SDK71_',
+            ],
+          }],
           ['win_z7!=0', {
             'msvs_settings': {
               # Generates debug info when win_z7=1
               # even if fastbuild=1 (that makes GenerateDebugInformation false).
               'VCLinkerTool': {
                 'GenerateDebugInformation': 'true',
               },
               'VCCLCompilerTool': {
                 'DebugInformationFormat': '1',
               }
@@ skipping 397 matching lines @@
               }],
               ['win_debug_OmitFramePointers==0', {
                 'OmitFramePointers': 'false',
                 # The above is not sufficient (http://crbug.com/106711): it
                 # simply eliminates an explicit "/Oy", but both /O2 and /Ox
                 # perform FPO regardless, so we must explicitly disable.
                 # We still want the false setting above to avoid having
                 # "/Oy /Oy-" and warnings about overriding.
                 'AdditionalOptions': ['/Oy-'],
               }],
+              ['win_analyze!=0', {

[scottmg, 2014/10/27 17:47:03]

just 'win_analyze' is fine.

+                # When win_analye is specified add the /analyze switch. There will be many

[scottmg, 2014/10/27 17:47:02]

rewrap to 80col

+                # warnings do disable warnings-as-errors. Putting it on additiona-options
+                # is the only practical way to do it for all projects.
+                # Also, disable various noisy warnings that have low value.
+                'AdditionalOptions': ['/analyze /WX- /wd6312 /wd6326 /wd28159 /wd28204 /wd28251 /wd28301 /wd28252 /wd28196 /wd6340 /wd6334 /wd6011 /wd6246 /wd6244 /wd28182'],

[scottmg, 2014/10/27 17:47:02]

make these separate items in a list, i.e.

'AdditionalOptions': [
  '/analyze',
  '/WX-',
  '/wd6312',  # Disables xyz.
  ...
]

+                # 6340 6334 6011 6246 6244 28182
+                # /analyze related warnings
+                #6312, # Possible infinite loop: use of the constant EXCEPTION_CONTINUE_EXECUTION in the exception-filter expression of a try-except
+                #6326, # Potential comparison of a constant with another constant.
+                #28159, # Consider using 'GetTickCount64' instead of 'GetTickCount'.
+                #28204, # Inconsistent SAL annotations
+                #28251, # Inconsistent SAL annotations
+                #28252, # Inconsistent SAL annotations
+                #28301, # Inconsistent SAL annotations
+                #28196, # The requirement that (precondition) is not satisfied.
+                # 6340 6334 6011 6246 6244 28182
+              }],
             ],
             'AdditionalOptions': [ '<@(win_debug_extra_cflags)', ],
           },
           'VCLinkerTool': {
             'LinkIncremental': '<(msvs_debug_link_incremental)',
             # ASLR makes debugging with windbg difficult because Chrome.exe and
             # Chrome.dll share the same base name. As result, windbg will
             # name the Chrome.dll module like chrome_<base address>, where
             # <base address> typically changes with each launch. This in turn
             # means that breakpoints in Chrome.dll don't stick from one launch
@@ skipping 2615 matching lines @@
     # settings in target dicts.  SYMROOT is a special case, because many other
     # Xcode variables depend on it, including variables such as
     # PROJECT_DERIVED_FILE_DIR.  When a source group corresponding to something
     # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the
     # files to appear (when present) in the UI as actual files and not red
     # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR,
     # and therefore SYMROOT, needs to be set at the project level.
     'SYMROOT': '<(DEPTH)/xcodebuild',
   },
 }