Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Issue 67673003: Move WeakPtrFactory members in jingle/ classes to the correct locations. (Closed)

Created:
7 years, 1 month ago by Wez
Modified:
7 years, 1 month ago
Reviewers:
awong
CC:
chromium-reviews, dmichael (off chromium)
Visibility:
Public.

Description

Move WeakPtrFactory members in jingle/ classes to the correct locations. BUG=303818 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=234152

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -18 lines) Patch
M jingle/glue/chrome_async_socket.h View 2 chunks +2 lines, -1 line 0 comments Download
M jingle/glue/chrome_async_socket.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M jingle/glue/proxy_resolving_client_socket.h View 1 chunk +4 lines, -1 line 0 comments Download
M jingle/glue/task_pump.h View 1 chunk +2 lines, -1 line 0 comments Download
M jingle/glue/task_pump.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M jingle/glue/thread_wrapper.h View 1 chunk +1 line, -1 line 0 comments Download
M jingle/glue/thread_wrapper.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M jingle/notifier/listener/non_blocking_push_client.h View 1 chunk +3 lines, -2 lines 0 comments Download
M jingle/notifier/listener/non_blocking_push_client.cc View 1 chunk +3 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Wez
PTAL
7 years, 1 month ago (2013-11-09 02:58:02 UTC) #1
awong
LGTM
7 years, 1 month ago (2013-11-09 17:18:16 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wez@chromium.org/67673003/1
7 years, 1 month ago (2013-11-09 18:22:19 UTC) #3
commit-bot: I haz the power
7 years, 1 month ago (2013-11-10 00:42:59 UTC) #4
Message was sent while issue was closed.
Change committed as 234152

Powered by Google App Engine
This is Rietveld 408576698