Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Unified Diff: sky/engine/bindings/core/v8/DictionaryHelperForCore.cpp

Issue 676723003: Remove postMessage, MessageChannel and MessagePort. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/engine/bindings/core/v8/Dictionary.cpp ('k') | sky/engine/bindings/core/v8/PostMessage.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/bindings/core/v8/DictionaryHelperForCore.cpp
diff --git a/sky/engine/bindings/core/v8/DictionaryHelperForCore.cpp b/sky/engine/bindings/core/v8/DictionaryHelperForCore.cpp
index 16ffd86af68f8a30fc83e86b7b61c6ae9ca1206a..a3e8f953d4d76628e7fceaf28d48b1b5f6e5e1a6 100644
--- a/sky/engine/bindings/core/v8/DictionaryHelperForCore.cpp
+++ b/sky/engine/bindings/core/v8/DictionaryHelperForCore.cpp
@@ -34,7 +34,6 @@
#include "bindings/core/v8/V8Element.h"
#include "bindings/core/v8/V8EventTarget.h"
#include "bindings/core/v8/V8MediaKeyError.h"
-#include "bindings/core/v8/V8MessagePort.h"
#include "bindings/core/v8/V8Path2D.h"
#include "bindings/core/v8/V8VoidCallback.h"
#include "bindings/core/v8/V8Window.h"
@@ -262,22 +261,6 @@ bool DictionaryHelper::get(const Dictionary& dictionary, const String& key, RefP
}
template <>
-bool DictionaryHelper::get(const Dictionary& dictionary, const String& key, MessagePortArray& value)
-{
- v8::Local<v8::Value> v8Value;
- if (!dictionary.get(key, v8Value))
- return false;
-
- ASSERT(dictionary.isolate());
- ASSERT(dictionary.isolate() == v8::Isolate::GetCurrent());
- if (blink::isUndefinedOrNull(v8Value))
- return true;
- bool success = false;
- value = toRefPtrWillBeMemberNativeArray<MessagePort, V8MessagePort>(v8Value, key, dictionary.isolate(), &success);
- return success;
-}
-
-template <>
bool DictionaryHelper::get(const Dictionary& dictionary, const String& key, HashSet<AtomicString>& value)
{
v8::Local<v8::Value> v8Value;
@@ -608,16 +591,4 @@ template bool DictionaryHelper::convert(const Dictionary&, Dictionary::Conversio
template bool DictionaryHelper::convert(const Dictionary&, Dictionary::ConversionContext&, const String& key, RefPtrWillBeMember<MediaKeyError>& value);
template bool DictionaryHelper::convert(const Dictionary&, Dictionary::ConversionContext&, const String& key, RefPtrWillBeMember<EventTarget>& value);
-template <>
-bool DictionaryHelper::convert(const Dictionary& dictionary, Dictionary::ConversionContext& context, const String& key, MessagePortArray& value)
-{
- Dictionary::ConversionContextScope scope(context);
-
- v8::Local<v8::Value> v8Value;
- if (!dictionary.get(key, v8Value))
- return true;
-
- return DictionaryHelper::get(dictionary, key, value);
-}
-
} // namespace blink
« no previous file with comments | « sky/engine/bindings/core/v8/Dictionary.cpp ('k') | sky/engine/bindings/core/v8/PostMessage.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698