Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(525)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 676723003: Remove postMessage, MessageChannel and MessagePort. (Closed)

Created:
6 years, 2 months ago by esprehn
Modified:
6 years, 2 months ago
Reviewers:
abarth-chromium
CC:
abarth-chromium, mojo-reviews_chromium.org, ojan
Base URL:
https://github.com/domokit/mojo.git@master
Visibility:
Public.

Description

Remove postMessage, MessageChannel and MessagePort. Sky uses Mojo services to communicate between embedded applications, not postMessage and its friends. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/d9e308b324ff2913ef917e37169fb2147b65af45

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -1789 lines) Patch
M sky/engine/bindings/core/v8/Dictionary.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/bindings/core/v8/Dictionary.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/bindings/core/v8/DictionaryHelperForCore.cpp View 3 chunks +0 lines, -29 lines 0 comments Download
D sky/engine/bindings/core/v8/PostMessage.h View 1 chunk +0 lines, -45 lines 0 comments Download
M sky/engine/bindings/core/v8/SerializedScriptValue.h View 4 chunks +4 lines, -18 lines 0 comments Download
M sky/engine/bindings/core/v8/SerializedScriptValue.cpp View 20 chunks +12 lines, -125 lines 0 comments Download
M sky/engine/bindings/core/v8/custom/V8HistoryCustom.cpp View 1 chunk +1 line, -1 line 0 comments Download
D sky/engine/bindings/core/v8/custom/V8MessageChannelCustom.cpp View 1 chunk +0 lines, -60 lines 0 comments Download
D sky/engine/bindings/core/v8/custom/V8MessageEventCustom.cpp View 1 chunk +0 lines, -157 lines 0 comments Download
D sky/engine/bindings/core/v8/custom/V8MessagePortCustom.cpp View 1 chunk +0 lines, -45 lines 0 comments Download
M sky/engine/bindings/core/v8/custom/V8WindowCustom.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/bindings/core/v8/custom/custom.gypi View 1 chunk +0 lines, -3 lines 0 comments Download
M sky/engine/bindings/core/v8/v8.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/bindings/templates/methods.cpp View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/core.gni View 5 chunks +0 lines, -9 lines 0 comments Download
D sky/engine/core/dom/MessageChannel.h View 1 chunk +0 lines, -64 lines 0 comments Download
D sky/engine/core/dom/MessageChannel.cpp View 1 chunk +0 lines, -64 lines 0 comments Download
D sky/engine/core/dom/MessageChannel.idl View 1 chunk +0 lines, -34 lines 0 comments Download
D sky/engine/core/dom/MessagePort.h View 1 chunk +0 lines, -124 lines 0 comments Download
D sky/engine/core/dom/MessagePort.cpp View 1 chunk +0 lines, -252 lines 0 comments Download
D sky/engine/core/dom/MessagePort.idl View 1 chunk +0 lines, -39 lines 0 comments Download
M sky/engine/core/events/CustomEvent.h View 1 chunk +1 line, -0 lines 0 comments Download
M sky/engine/core/events/EventTarget.h View 2 chunks +0 lines, -2 lines 0 comments Download
M sky/engine/core/events/EventTarget.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M sky/engine/core/events/EventTargetFactory.in View 1 chunk +0 lines, -1 line 0 comments Download
D sky/engine/core/events/MessageEvent.h View 1 chunk +0 lines, -139 lines 0 comments Download
D sky/engine/core/events/MessageEvent.cpp View 1 chunk +0 lines, -207 lines 0 comments Download
D sky/engine/core/events/MessageEvent.idl View 1 chunk +0 lines, -46 lines 0 comments Download
M sky/engine/core/frame/LocalDOMWindow.h View 3 chunks +1 line, -3 lines 0 comments Download
M sky/engine/core/frame/LocalDOMWindow.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/frame/Window.idl View 1 chunk +0 lines, -15 lines 0 comments Download
M sky/engine/core/loader/FrameLoaderClient.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/public/platform/Platform.h View 2 chunks +0 lines, -9 lines 0 comments Download
D sky/engine/public/platform/WebMessagePortChannel.h View 1 chunk +0 lines, -78 lines 0 comments Download
D sky/engine/public/platform/WebMessagePortChannelClient.h View 1 chunk +0 lines, -51 lines 0 comments Download
M sky/engine/public/web/WebDOMEvent.h View 1 chunk +0 lines, -1 line 0 comments Download
D sky/engine/public/web/WebDOMMessageEvent.h View 1 chunk +0 lines, -64 lines 0 comments Download
M sky/engine/public/web/WebFrame.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/public/web/WebFrameClient.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/web/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/web/FrameLoaderClientImpl.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/web/WebDOMEvent.cpp View 1 chunk +0 lines, -6 lines 0 comments Download
D sky/engine/web/WebDOMMessageEvent.cpp View 1 chunk +0 lines, -80 lines 0 comments Download
M sky/engine/web/WebLocalFrameImpl.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/web/WebSerializedScriptValue.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
abarth-chromium
lgtm
6 years, 2 months ago (2014-10-23 20:11:45 UTC) #1
esprehn
6 years, 2 months ago (2014-10-23 20:17:54 UTC) #2
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
d9e308b324ff2913ef917e37169fb2147b65af45.

Powered by Google App Engine
This is Rietveld 408576698