Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issue 676663002: Paint Profiler: fix right boundary of selection window (Closed)

Created:
6 years, 2 months ago by caseq
Modified:
6 years, 2 months ago
Reviewers:
yurys, pfeldman, loislo
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

Paint Profiler: fix right boundary of selection window - use "open" type for right end-point of selection interval (i.e. "[)", exlude the end value) - adjust window calculation to better match actual bars in the overview. BUG=426147 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184256

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M Source/devtools/front_end/timeline/PaintProfilerView.js View 4 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
caseq
6 years, 2 months ago (2014-10-23 09:34:16 UTC) #2
pfeldman
lgtm.
6 years, 2 months ago (2014-10-23 09:51:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/676663002/1
6 years, 2 months ago (2014-10-23 10:09:27 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-23 11:11:00 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 184256

Powered by Google App Engine
This is Rietveld 408576698