Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(359)

Issue 676613002: Cleanup: Remove unused enable_eglimage variable and #define. (Closed)

Created:
6 years, 2 months ago by Lei Zhang
Modified:
6 years, 1 month ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Cleanup: Remove unused enable_eglimage variable and #define. Committed: https://crrev.com/82ca3b654cda337fe5bfab06438905c0d0b47660 Cr-Commit-Position: refs/heads/master@{#301556}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : fix rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -9 lines) Patch
M build/common.gypi View 1 2 chunks +0 lines, -8 lines 0 comments Download
M build/config/BUILD.gn View 1 2 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 18 (7 generated)
Lei Zhang
6 years, 2 months ago (2014-10-23 07:16:44 UTC) #2
scherkus (not reviewing)
wow blast from the past! lgtm
6 years, 2 months ago (2014-10-23 21:15:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/676613002/1
6 years, 2 months ago (2014-10-23 21:33:31 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/19661) linux_chromium_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel/builds/2442)
6 years, 2 months ago (2014-10-23 21:45:33 UTC) #7
Lei Zhang
+brettw for build/config/BUILD.gn. I'll have to fix the merge since I have another CL that's ...
6 years, 2 months ago (2014-10-23 21:55:18 UTC) #9
brettw
build/config lgtm
6 years, 1 month ago (2014-10-25 15:53:32 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/676613002/1
6 years, 1 month ago (2014-10-27 18:19:22 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel/builds/6516)
6 years, 1 month ago (2014-10-27 18:27:25 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/676613002/40001
6 years, 1 month ago (2014-10-27 21:02:46 UTC) #16
commit-bot: I haz the power
Committed patchset #3 (id:40001)
6 years, 1 month ago (2014-10-28 02:42:36 UTC) #17
commit-bot: I haz the power
6 years, 1 month ago (2014-10-28 02:43:31 UTC) #18
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/82ca3b654cda337fe5bfab06438905c0d0b47660
Cr-Commit-Position: refs/heads/master@{#301556}

Powered by Google App Engine
This is Rietveld 408576698