Issue 676603002: Oilpan: HeapTest: FinalizationObserverWithHashMap should not leave a Persistent object.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 676603002: Oilpan: HeapTest: FinalizationObserverWithHashMap should not leave a Persistent object. (Closed)

Created:
6 years, 2 months ago by tkent

Modified:
6 years, 2 months ago

Reviewers:
oilpan-reviews, haraken

CC:
blink-reviews, kouhei+heap_chromium.org, Mads Ager (chromium), mkwst+moarreviews_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

Oilpan: HeapTest: FinalizationObserverWithHashMap should not leave a Persistent object. Clear the Persistent HeapHashMap at the end of HeapTest.FinalizationObserver. HeapTest.CheckAndMarkPointer assumes there are no Persistent objects, and triggers GC without visiting Persistent handles. If HeapTest.CheckAndMarkPointer is executed after HeapTest.FinalizationObserver, and a normal GC happens, a Visitor accesses deallocated memory pointed by the Persistent. BUG=none Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184238