Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(434)

Unified Diff: LayoutTests/http/tests/serviceworker/resources/cache-put-worker.js

Issue 676563002: Service Worker: Annotate IDLs with [TypeChecking] to turn it on (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Remove TypeChecking=Unrestricted Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/http/tests/serviceworker/cache-put-expected.txt ('k') | Source/modules/serviceworkers/Body.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: LayoutTests/http/tests/serviceworker/resources/cache-put-worker.js
diff --git a/LayoutTests/http/tests/serviceworker/resources/cache-put-worker.js b/LayoutTests/http/tests/serviceworker/resources/cache-put-worker.js
index 6f080e3ee5ddac8ac0461b34e446bbdf1498b20b..b877c9976960580c566cdaa3706a743b460f8f57 100644
--- a/LayoutTests/http/tests/serviceworker/resources/cache-put-worker.js
+++ b/LayoutTests/http/tests/serviceworker/resources/cache-put-worker.js
@@ -160,16 +160,12 @@ cache_test(function(cache) {
'Cache.put should only accept a Request object as the request.');
}, 'Cache.put with an invalid request');
-// TODO: This test currently causes a renderer crash. Enable test again once the
-// crash is resolved. http://crbug.com/426153
-if (false) {
- cache_test(function(cache) {
- return assert_promise_rejects(
- cache.put(new_test_request(), 'Hello world!'),
- new TypeError(),
- 'Cache.put should only accept a Response object as the response.');
- }, 'Cache.put with an invalid response');
-}
+cache_test(function(cache) {
+ return assert_promise_rejects(
+ cache.put(new_test_request(), 'Hello world!'),
+ new TypeError(),
+ 'Cache.put should only accept a Response object as the response.');
+ }, 'Cache.put with an invalid response');
cache_test(function(cache) {
return assert_promise_rejects(
@@ -207,13 +203,9 @@ cache_test(function(cache) {
'Cache.put should throw a TypeError for non-GET requests.');
}, 'Cache.put with a non-GET request');
-// TODO: This test currently causes a renderer crash. Enable test again once the
-// crash is resolved. http://crbug.com/426153
-if (false) {
- cache_test(function(cache) {
- return assert_promise_rejects(
- cache.put(new_test_request(), null),
- new TypeError(),
- 'Cache.put should throw a TypeError for an empty response.');
- }, 'Cache.put with an empty response');
-}
+cache_test(function(cache) {
+ return assert_promise_rejects(
+ cache.put(new_test_request(), null),
+ new TypeError(),
+ 'Cache.put should throw a TypeError for an empty response.');
+ }, 'Cache.put with an empty response');
« no previous file with comments | « LayoutTests/http/tests/serviceworker/cache-put-expected.txt ('k') | Source/modules/serviceworkers/Body.idl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698