Source/platform/fonts/shaping/SimpleShaper.h - Issue 676523003: Offset-only GlyphBuffer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/platform/fonts/shaping/SimpleShaper.h

Issue 676523003: Offset-only GlyphBuffer (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: review comments Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/platform/fonts/shaping/SimpleShaper.h

diff --git a/Source/platform/fonts/shaping/SimpleShaper.h b/Source/platform/fonts/shaping/SimpleShaper.h

index 29f1ef37c16e9fec0e233ca25fd8d15d86c33b2a..d848ff5a390ccb1f5264949c33ba1a3922bd4079 100644

--- a/Source/platform/fonts/shaping/SimpleShaper.h

+++ b/Source/platform/fonts/shaping/SimpleShaper.h

@@ -82,7 +82,7 @@ private:

GlyphData glyphDataForCharacter(CharacterData&, bool normalizeSpace = false);

float characterWidth(UChar32, const GlyphData&) const;

void cacheFallbackFont(const SimpleFontData*, const SimpleFontData* primaryFont);

- float adjustSpacing(float, const CharacterData&, const SimpleFontData&, GlyphBuffer*);

+ float adjustSpacing(float, const CharacterData&);

void updateGlyphBounds(const GlyphData&, float width, bool firstCharacter);

template <typename TextIterator>