Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Issue 676503003: Exclude zip-file loading from "Load Unpacked Extension" (Closed)

Created:
6 years, 2 months ago by elijahtaylor1
Modified:
6 years, 2 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Exclude zip-file loading from "Load Unpacked Extension" This was only implemented half-way, and the file picker still limited choices to directories. So this code only got run (incorrectly) by selecting a folder that ends in .zip (which happens on ChromeOS for a mounted zip archive). BUG=418753 Committed: https://crrev.com/15de820523bc885041fdebc72cf9b5d966a0c51b Cr-Commit-Position: refs/heads/master@{#301141}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -21 lines) Patch
M chrome/browser/ui/webui/extensions/extension_loader_handler.cc View 1 chunk +8 lines, -21 lines 0 comments Download

Messages

Total messages: 16 (6 generated)
elijahtaylor1
PTAL
6 years, 2 months ago (2014-10-22 22:18:10 UTC) #2
asargent_no_longer_on_chrome
lgtm
6 years, 2 months ago (2014-10-23 20:44:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/676503003/1
6 years, 2 months ago (2014-10-23 20:46:28 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/19633)
6 years, 2 months ago (2014-10-23 20:54:44 UTC) #7
asargent_no_longer_on_chrome
Oops, looks like you need someone from chrome/browser/ui/webui/extensions/OWNERS to review. On Thu, Oct 23, 2014 ...
6 years, 2 months ago (2014-10-23 20:58:33 UTC) #8
elijahtaylor1
PTAL, this time with actual OWNERS :)
6 years, 2 months ago (2014-10-23 21:06:31 UTC) #11
miket_OOO
lgtm
6 years, 2 months ago (2014-10-24 17:44:56 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/676503003/1
6 years, 2 months ago (2014-10-24 17:47:35 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-24 17:52:31 UTC) #15
commit-bot: I haz the power
6 years, 2 months ago (2014-10-24 17:53:25 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/15de820523bc885041fdebc72cf9b5d966a0c51b
Cr-Commit-Position: refs/heads/master@{#301141}

Powered by Google App Engine
This is Rietveld 408576698