Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issue 6765026: [Arguments] Fix a small bug and change some test expectations. (Closed)

Created:
9 years, 8 months ago by Kevin Millikin (Chromium)
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

[Arguments] Fix a small bug and change some test expectations. When handling duplicate parameter names, the first duplicate named parameter "won" the prize of being aliased by the arguments object. It should be the last duplicate that wins. Also, remove the FAIL expectation for some tests that we now pass. R=ager@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=7441

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -15 lines) Patch
M src/runtime.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M test/mozilla/mozilla.status View 1 chunk +0 lines, -5 lines 0 comments Download
M test/sputnik/sputnik.status View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Kevin Millikin (Chromium)
9 years, 8 months ago (2011-03-30 13:35:15 UTC) #1
Mads Ager (chromium)
9 years, 8 months ago (2011-03-30 13:45:19 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698