Move the dispatching of extension messages out of RenderThread. This also moves a bunch of exten...

Move the dispatching of extension messages out of RenderThread.  This also moves a bunch of extension related state out of RenderThread.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=79699

[Matt Perry, 2011-03-29 00:48:29]

LGTM with one small nit.

http://codereview.chromium.org/6765011/diff/1/chrome/renderer/extensions/exte...
File chrome/renderer/extensions/extension_dispatcher.cc (right):

http://codereview.chromium.org/6765011/diff/1/chrome/renderer/extensions/exte...
chrome/renderer/extensions/extension_dispatcher.cc:32: g_extension_dispatcher =
this;
CHECK that this is NULL beforehand?

It's weird that this is a singleton class, but has a public constructor. Do you
plan on changing that in an upcoming refactor?

http://codereview.chromium.org/6765011/diff/1/chrome/renderer/render_thread.cc
File chrome/renderer/render_thread.cc (right):

http://codereview.chromium.org/6765011/diff/1/chrome/renderer/render_thread.c...
chrome/renderer/render_thread.cc:1047: bool restrict_to_extensions =
v8_extensions_[v8_extension_name];
the restrict_to_extensions boolean is something that only the
ExtensionDispatcher-registered extensions will use. So you might consider moving
it out of this class and into ExtensionDispatcher if you want to purge extension
references from this file. Up to you, if and when you want to do this.

[jam, 2011-03-29 04:55:37]

http://codereview.chromium.org/6765011/diff/1/chrome/renderer/extensions/exte...
File chrome/renderer/extensions/extension_dispatcher.cc (right):

http://codereview.chromium.org/6765011/diff/1/chrome/renderer/extensions/exte...
chrome/renderer/extensions/extension_dispatcher.cc:32: g_extension_dispatcher =
this;
On 2011/03/29 00:48:29, Matt Perry wrote:
> CHECK that this is NULL beforehand?

DONE

> 
> It's weird that this is a singleton class, but has a public constructor.

I think that's fine, i.e. RenderThread and RenderProcess are both like that.

> Do you plan on changing that in an upcoming refactor?

I'm actually not sure yet how this class will be accessed.  It depends on how
the rest of the refactoring goes.  I would like to remove this getter though.

http://codereview.chromium.org/6765011/diff/1/chrome/renderer/render_thread.cc
File chrome/renderer/render_thread.cc (right):

http://codereview.chromium.org/6765011/diff/1/chrome/renderer/render_thread.c...
chrome/renderer/render_thread.cc:1047: bool restrict_to_extensions =
v8_extensions_[v8_extension_name];
On 2011/03/29 00:48:29, Matt Perry wrote:
> the restrict_to_extensions boolean is something that only the
> ExtensionDispatcher-registered extensions will use. So you might consider
moving
> it out of this class and into ExtensionDispatcher if you want to purge
extension
> references from this file. Up to you, if and when you want to do this.

good point, done