Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 676483002: Reland roll android_tools and breakpad to the latest. (Closed)

Created:
6 years, 1 month ago by Fabrice (no longer in Chrome)
Modified:
6 years, 1 month ago
CC:
chromium-reviews, klundberg+watch_chromium.org, erikwright+watch_chromium.org, yfriedman+watch_chromium.org, Torne
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Reland Roll android_tools and breakpad to the latest. Compared to the previous CL, this picks up in breakpad: Fix breakpad on mips and x86_64 for the NDK r10c update. Original issue's description: > Revert of Roll android_tools and breakpad to the latest. (patchset #5 id:80001 of https://codereview.chromium.org/671633003/) > > Reason for revert: > Downstream x64 and mips bots didn't like it. > > Original issue's description: > > Roll android_tools and breakpad to the latest. > > > > This picks up in android_tools: > > Updated SDK build tools to 21.0.1 and removed old versions. > > Upgrade NDK to r10c. > > > > And in breakpad: > > Update breakpad to support Android NDK r10c > > Fixing the Mac Inspector build by adding the launch_report dependency to the breakpadUtilities dylib project after it got pulled out from Inspector.mm. > > Refactor .so name detection logic in minidump/linux_dumper. > > The process uptime computation when the Windows out-of-process Crash Generation Server is used is done by subtracting the crashing process creation time from the current time when the crash is generated. > > Linux multiprocess crash reporter: use pipe instead of socketpair in the client. > > Remove workaround for Linux credential-passing bug. > > > > TBR=brettw, danakj > > NOTRY=true > > BUG=424680, 425077, 358831 > > > > Committed: https://crrev.com/79bd5f12620f81dd241984d925b87a888e1dc37b > > Cr-Commit-Position: refs/heads/master@{#300671} > > TBR=brettw@chromium.org,primiano@chromium.org,rmcilroy@chromium.org,aurimas@chromium.org,danakj@chromium.org,fdegans@chromium.org > NOTREECHECKS=true > NOTRY=true > BUG=424680, 425077, 358831 > > Committed: https://crrev.com/e6319d7f7d5c2fc96c9cb1f5a81ae16bde19f068 > Cr-Commit-Position: refs/heads/master@{#300688} TBR=brettw@chromium.org,primiano@chromium.org,rmcilroy@chromium.org,aurimas@chromium.org,danakj@chromium.org,ppi@chromium.org BUG=424680, 425077, 358831 Committed: https://crrev.com/27660a3c6e308e9293745697433747e0a4fafae0 Cr-Commit-Position: refs/heads/master@{#301087}

Patch Set 1 #

Patch Set 2 : Breakpad fix + rebase #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -20 lines) Patch
M DEPS View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M base/sys_info_android.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M build/android/pylib/constants.py View 1 1 chunk +1 line, -1 line 0 comments Download
M build/common.gypi View 1 4 chunks +4 lines, -4 lines 0 comments Download
M build/config/android/config.gni View 1 2 1 chunk +1 line, -1 line 0 comments Download
M build/get_landmines.py View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/android_platform/README.chromium View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/android_platform/development/scripts/symbol.py View 1 3 chunks +8 lines, -10 lines 0 comments Download

Messages

Total messages: 13 (3 generated)
Fabrice (no longer in Chrome)
Created Revert of Revert of Roll android_tools and breakpad to the latest.
6 years, 1 month ago (2014-10-22 17:48:37 UTC) #1
Primiano Tucci (use gerrit)
On 2014/10/22 17:48:37, Fabrice de Gans wrote: > Created Revert of Revert of Roll android_tools ...
6 years, 1 month ago (2014-10-23 09:30:50 UTC) #2
Fabrice (no longer in Chrome)
Yes, I didn't know you could apply a new patch set on a CL that ...
6 years, 1 month ago (2014-10-23 09:45:30 UTC) #3
Primiano Tucci (use gerrit)
On 2014/10/23 09:45:30, Fabrice de Gans wrote: > Yes, I didn't know you could apply ...
6 years, 1 month ago (2014-10-23 10:18:56 UTC) #4
Primiano Tucci (use gerrit)
LGTM
6 years, 1 month ago (2014-10-24 11:14:47 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/676483002/190001
6 years, 1 month ago (2014-10-24 11:16:14 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/83448) win_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/78021) android_aosp ...
6 years, 1 month ago (2014-10-24 11:19:04 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/676483002/210001
6 years, 1 month ago (2014-10-24 11:23:20 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:210001)
6 years, 1 month ago (2014-10-24 13:00:25 UTC) #12
commit-bot: I haz the power
6 years, 1 month ago (2014-10-24 13:01:17 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/27660a3c6e308e9293745697433747e0a4fafae0
Cr-Commit-Position: refs/heads/master@{#301087}

Powered by Google App Engine
This is Rietveld 408576698