Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(330)

Issue 676453002: Revert of Roll android_tools and breakpad to the latest. (Closed)

Created:
6 years, 2 months ago by ppi
Modified:
6 years, 2 months ago
CC:
chromium-reviews, klundberg+watch_chromium.org, erikwright+watch_chromium.org, yfriedman+watch_chromium.org, Torne
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Roll android_tools and breakpad to the latest. (patchset #5 id:80001 of https://codereview.chromium.org/671633003/) Reason for revert: Downstream x64 and mips bots didn't like it. Original issue's description: > Roll android_tools and breakpad to the latest. > > This picks up in android_tools: > Updated SDK build tools to 21.0.1 and removed old versions. > Upgrade NDK to r10c. > > And in breakpad: > Update breakpad to support Android NDK r10c > Fixing the Mac Inspector build by adding the launch_report dependency to the breakpadUtilities dylib project after it got pulled out from Inspector.mm. > Refactor .so name detection logic in minidump/linux_dumper. > The process uptime computation when the Windows out-of-process Crash Generation Server is used is done by subtracting the crashing process creation time from the current time when the crash is generated. > Linux multiprocess crash reporter: use pipe instead of socketpair in the client. > Remove workaround for Linux credential-passing bug. > > TBR=brettw, danakj > NOTRY=true > BUG=424680, 425077, 358831 > > Committed: https://crrev.com/79bd5f12620f81dd241984d925b87a888e1dc37b > Cr-Commit-Position: refs/heads/master@{#300671} TBR=brettw@chromium.org,primiano@chromium.org,rmcilroy@chromium.org,aurimas@chromium.org,danakj@chromium.org,fdegans@chromium.org NOTREECHECKS=true NOTRY=true BUG=424680, 425077, 358831 Committed: https://crrev.com/e6319d7f7d5c2fc96c9cb1f5a81ae16bde19f068 Cr-Commit-Position: refs/heads/master@{#300688}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -19 lines) Patch
M DEPS View 2 chunks +2 lines, -2 lines 0 comments Download
M base/sys_info_android.cc View 1 chunk +2 lines, -1 line 0 comments Download
M build/android/pylib/constants.py View 1 chunk +1 line, -1 line 0 comments Download
M build/common.gypi View 4 chunks +4 lines, -4 lines 0 comments Download
M build/config/android/config.gni View 1 chunk +1 line, -1 line 0 comments Download
M build/get_landmines.py View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/android_platform/README.chromium View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/android_platform/development/scripts/symbol.py View 3 chunks +10 lines, -8 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
ppi
Created Revert of Roll android_tools and breakpad to the latest.
6 years, 2 months ago (2014-10-22 16:36:59 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/676453002/1
6 years, 2 months ago (2014-10-22 16:38:30 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-22 16:41:21 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/e6319d7f7d5c2fc96c9cb1f5a81ae16bde19f068 Cr-Commit-Position: refs/heads/master@{#300688}
6 years, 2 months ago (2014-10-22 16:42:10 UTC) #4
Fabrice (no longer in Chrome)
6 years, 2 months ago (2014-10-22 17:48:36 UTC) #5
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/676483002/ by fdegans@chromium.org.

The reason for reverting is: Reland after fix for mips and x86_64 are in
breakpad..

Powered by Google App Engine
This is Rietveld 408576698