Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issue 676423004: Merge CrosDisksClientStubImpl into FakeCrosDisksClient (Closed)

Created:
6 years, 1 month ago by satorux1
Modified:
6 years, 1 month ago
Reviewers:
hashimoto
CC:
chromium-reviews, stevenjb+watch_chromium.org, hashimoto+watch_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Merge CrosDisksClientStubImpl into FakeCrosDisksClient Move the fake mounting logic from CrosDisksClientStubImpl to FakeCrosDsisksClient, with some simplification. The fake behaviors are used in FileManagerBrowserTest's OpenZipFiles test. The test is currently disabled for a performance reason, but I've confirmed that the test passes with --gtest_also_run_disabled_tests. TEST=out/Release/browser_tests --gtest_filter='*OpenZipFiles*' --gtest_also_run_disabled_tests BUG=309506 Committed: https://crrev.com/8fd29380c9f675f931121080c22a4fef520140f5 Cr-Commit-Position: refs/heads/master@{#302053}

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : remove static #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -186 lines) Patch
M chromeos/chromeos.gyp View 2 chunks +2 lines, -2 lines 0 comments Download
M chromeos/dbus/cros_disks_client.cc View 1 3 chunks +2 lines, -183 lines 0 comments Download
M chromeos/dbus/fake_cros_disks_client.h View 2 chunks +9 lines, -1 line 0 comments Download
M chromeos/dbus/fake_cros_disks_client.cc View 1 2 3 chunks +81 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
satorux1
6 years, 1 month ago (2014-10-29 05:42:21 UTC) #2
hashimoto
lgtm https://codereview.chromium.org/676423004/diff/20001/chromeos/dbus/fake_cros_disks_client.cc File chromeos/dbus/fake_cros_disks_client.cc (right): https://codereview.chromium.org/676423004/diff/20001/chromeos/dbus/fake_cros_disks_client.cc#newcode19 chromeos/dbus/fake_cros_disks_client.cc:19: static MountError PerformFakeMount(const std::string& source_path, nit: "static" unneeded.
6 years, 1 month ago (2014-10-29 06:43:53 UTC) #3
satorux1
https://codereview.chromium.org/676423004/diff/20001/chromeos/dbus/fake_cros_disks_client.cc File chromeos/dbus/fake_cros_disks_client.cc (right): https://codereview.chromium.org/676423004/diff/20001/chromeos/dbus/fake_cros_disks_client.cc#newcode19 chromeos/dbus/fake_cros_disks_client.cc:19: static MountError PerformFakeMount(const std::string& source_path, On 2014/10/29 06:43:53, hashimoto ...
6 years, 1 month ago (2014-10-29 06:47:02 UTC) #4
hashimoto
lgtm
6 years, 1 month ago (2014-10-29 06:47:57 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/676423004/40001
6 years, 1 month ago (2014-10-30 07:41:38 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
6 years, 1 month ago (2014-10-30 08:23:22 UTC) #8
commit-bot: I haz the power
6 years, 1 month ago (2014-10-30 08:23:59 UTC) #9
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/8fd29380c9f675f931121080c22a4fef520140f5
Cr-Commit-Position: refs/heads/master@{#302053}

Powered by Google App Engine
This is Rietveld 408576698