Add build target for inputview.

third_party/google_input_tools/update.py

 #!/usr/bin/python
-# Copyright (c) 2014 The Chromium Authors. All rights reserved.             
+# Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import logging
 import optparse
 import os
 import re
 import shutil
 import sys
 
 _BASE_REGEX_STRING = '^\s*goog\.%s\(\s*[\'"](.+)[\'"]\s*\)'
 require_regex = re.compile(_BASE_REGEX_STRING % 'require')
 provide_regex = re.compile(_BASE_REGEX_STRING % 'provide')
 
+preamble = [

[bruthig, 2014/10/28 19:20:44]

You could do
preamble = os.linesep.join(['Line1', 'Line2'])
and then you wouldn't have to loop over the list items when you are writing the
preamble out on line 219.

[kevers, 2014/10/29 14:27:19]

Done.

+  '# Copyright 2014 The Chromium Authors. All rights reserved.',
+  '# Use of this source code is governed by a BSD-style license that can be',
+  '# found in the LICENSE file.',
+  '',
+  '# This file is auto-generated using update.py.',
+  '']
+
 # Entry-points required to build a virtual keyboard.
 namespaces = [
   'i18n.input.chrome.inputview.Controller',
   'i18n.input.chrome.inputview.content.compact.letter',
   'i18n.input.chrome.inputview.content.compact.util',
   'i18n.input.chrome.inputview.content.compact.symbol',
   'i18n.input.chrome.inputview.content.compact.more',
   'i18n.input.chrome.inputview.content.compact.numberpad',
   'i18n.input.chrome.inputview.content.ContextlayoutUtil',
   'i18n.input.chrome.inputview.content.util',
@@ skipping 137 matching lines @@
   return path
 
 
 def CopyFile(source, target):
   """Copies a file from the source to the target location.
 
   Args:
     source: Path to the source file to copy.
     target: Path to the target location to copy the file.
   """
-  print '%s --> %s' % (source, target)
+
   if not os.path.exists(os.path.dirname(target)):
     os.makedirs(os.path.dirname(target))
   shutil.copy(source, target)
 
 
-def UpdateFile(filename, input_source, closure_source):
+def UpdateFile(filename, input_source, closure_source, target_files):
     """Updates files in third_party/google_input_tools.
+
     Args:
       filename: The file to update.
       input_source: Root of the google_input_tools sandbox.
       closure_source: Root of the closure_library sandbox.
+      target_files: List of relative paths to target files.
     """
+
     target = ''
     if filename.startswith(input_source):
       target = os.path.join('src', filename[len(input_source)+1:])
     elif filename.startswith(closure_source):
       target = os.path.join('third_party/closure_library', \
                             filename[len(closure_source)+1:])
     if len(target) > 0:
       CopyFile(filename, target)
+      target_files.append(os.path.relpath(target, os.getcwd()))
 
 
+def GenerateBuildFile(target_files):
+  """Updates inputview.gypi.
+
+  Args:
+    target_files: List of files required to build inputview.js.
+  """
+

[bruthig, 2014/10/28 19:20:45]

I'm not 100% sure if it will work for the formatting you are trying to achieve
but it might be worth checking out the the json.dumps function.  That way you
could build up your python dict and lists and simply output the string and not
have to worry about matching braces or escaping special characters.

Example:
json_data= {'key1' : ['list_item1', 'list_item2'], 'key2' : 'value2']
json.dumps(json_data, sort_keys=True, indent=2, separators=(',', ': '))

[kevers, 2014/10/29 14:27:20]

Done.

+  sorted_files = sorted(target_files)
+  file_handle = open('inputview.gypi', 'w')
+  try:
+    for line in preamble:
+      file_handle.write('%s\n' % line)
+    file_handle.write("{\n")
+    file_handle.write("  'variables': {\n")
+    file_handle.write("    'inputview_sources': [\n")
+    for name in sorted_files:
+      file_handle.write("      '%s',\n" % name)
+    file_handle.write("    ],\n")
+    file_handle.write("  }\n")
+    file_handle.write("}\n")
+  finally:
+    file_handle.close()
+
 def main():
   """The entrypoint for this script."""
 
   logging.basicConfig(format='update.py: %(message)s', level=logging.INFO)
 
   usage = 'usage: %prog [options] arg'
   parser = optparse.OptionParser(usage)
   parser.add_option('-i',
                     '--input',
                     dest='input',
                     action='append',
                     help='Path to the google-input-tools sandbox.')
   parser.add_option('-l',
                      '--lib',
                      dest='lib',
                      action='store',
                      help='Path to the closure-library sandbox.')
 
   (options, args) = parser.parse_args()
 
   input_path = GetGoogleInputToolsSandboxFromOptions(options)
   closure_library_path = GetClosureLibrarySandboxFromOptions(options)
 
-  print 'iput_path = %s' % input_path
-  print 'closure_library_path = %s' % closure_library_path
-
   if not os.path.isdir(input_path):
     print 'Could not find google-input-tools sandbox.'
     exit(1)
   if not os.path.isdir(closure_library_path):
     print 'Could not find closure-library sandbox.'
     exit(1)
 
   (providers, requirements) = \
       ExpandDirectories([os.path.join(input_path, 'chrome'),
                          closure_library_path])
 
   dependencies = set()
-
   for name in namespaces:
     ExtractDependencies(name, providers, requirements, dependencies)
 
+  target_files = []
   for name in dependencies:
-    UpdateFile(name, input_path, closure_library_path)
+    UpdateFile(name, input_path, closure_library_path, target_files)
+
+  GenerateBuildFile(target_files)
 
 if __name__ == '__main__':
   main()