Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 676423002: Start moving to the new canvas structure. (Closed)

Created:
6 years, 1 month ago by jcgregorio
Modified:
6 years, 1 month ago
Reviewers:
robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Start moving to the new canvas structure. Adds DrawingMethods with some of the methods it defines. Context is now an implementation of DrawingMethods. The sample.js file now shows how the context is used. Not much new code here, that's mostly in DrawingMethods::DrawPath, most everything else is a code move. BUG=skia: Committed: https://skia.googlesource.com/skia/+/5e44b00392e791088b693a0b462b107b0b5a91ba

Patch Set 1 #

Patch Set 2 : rebase and cleaning #

Total comments: 9

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+241 lines, -373 lines) Patch
D experimental/SkV8Example/BaseContext.h View 1 chunk +0 lines, -82 lines 0 comments Download
D experimental/SkV8Example/BaseContext.cpp View 1 chunk +0 lines, -284 lines 0 comments Download
A experimental/SkV8Example/DrawingMethods.h View 1 2 1 chunk +57 lines, -0 lines 0 comments Download
A experimental/SkV8Example/DrawingMethods.cpp View 1 2 1 chunk +172 lines, -0 lines 0 comments Download
M experimental/SkV8Example/JsContext.h View 3 chunks +3 lines, -3 lines 0 comments Download
M experimental/SkV8Example/js/sample.js View 1 chunk +7 lines, -2 lines 0 comments Download
M gyp/v8.gyp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
jcgregorio
6 years, 1 month ago (2014-10-27 15:39:17 UTC) #2
robertphillips
lgtm + some questions https://codereview.chromium.org/676423002/diff/20001/experimental/SkV8Example/DrawingMethods.cpp File experimental/SkV8Example/DrawingMethods.cpp (right): https://codereview.chromium.org/676423002/diff/20001/experimental/SkV8Example/DrawingMethods.cpp#newcode120 experimental/SkV8Example/DrawingMethods.cpp:120: void DrawingMethods::GetWidth(v8::Local<v8::String> name, align this ...
6 years, 1 month ago (2014-10-27 16:11:17 UTC) #3
jcgregorio
https://codereview.chromium.org/676423002/diff/20001/experimental/SkV8Example/DrawingMethods.cpp File experimental/SkV8Example/DrawingMethods.cpp (right): https://codereview.chromium.org/676423002/diff/20001/experimental/SkV8Example/DrawingMethods.cpp#newcode120 experimental/SkV8Example/DrawingMethods.cpp:120: void DrawingMethods::GetWidth(v8::Local<v8::String> name, On 2014/10/27 16:11:17, robertphillips wrote: > ...
6 years, 1 month ago (2014-10-27 16:30:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/676423002/40001
6 years, 1 month ago (2014-10-27 16:31:03 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-10-27 17:27:06 UTC) #7
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as 5e44b00392e791088b693a0b462b107b0b5a91ba

Powered by Google App Engine
This is Rietveld 408576698