Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Unified Diff: tools/auto_bisect/bisect_perf_regression.py

Issue 676403005: Make bisect tool check for new V8 roll description, "based on <git-hash>" (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/auto_bisect/bisect_perf_regression.py
diff --git a/tools/auto_bisect/bisect_perf_regression.py b/tools/auto_bisect/bisect_perf_regression.py
index 2a7f3938c2212955af989ff691485e3269446442..7e0e359c3f19eac57a04798b737c05b0a6f9ce3b 100755
--- a/tools/auto_bisect/bisect_perf_regression.py
+++ b/tools/auto_bisect/bisect_perf_regression.py
@@ -1882,9 +1882,6 @@ class BisectPerformanceMetrics(object):
regex_results = version_re.search(revision_info['subject'])
if regex_results:
git_revision = None
- # TODO (prasadv): Support the v8 git migration based subject
- # "based on <githash>"
- # Look for "based on bleeding_edge" and parse out revision
if 'based on bleeding_edge' in revision_info['subject']:
try:
bleeding_edge_revision = revision_info['subject'].split(
@@ -1904,6 +1901,16 @@ class BisectPerformanceMetrics(object):
return git_revision
except (IndexError, ValueError):
pass
+ else:
+ # V8 rolls description changed after V8 git migration, new description
+ # includes "Version 3.X.Y (based on <git hash>)"
+ try:
+ rxp = re.compile('based on (?P<git_revision>[a-fA-F0-9]+)')
+ re_results = rxp.search(revision_info['subject'])
+ if re_results:
+ return re_results.group('git_revision')
+ except (IndexError, ValueError):
+ pass
if not git_revision:
# Wasn't successful, try the old way of looking for "Prepare push to"
git_revision = source_control.ResolveToRevision(
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698