Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 676403003: Revert of Changed api to notify when watched directory is deleted. (Closed)

Created:
6 years, 1 month ago by Avi (use Gerrit)
Modified:
6 years, 1 month ago
Reviewers:
mtomasz, yoshiki, yawano
CC:
chromium-reviews, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, yoshiki+watch_chromium.org, rginda+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Changed api to notify when watched directory is deleted. (patchset #16 id:300001 of https://codereview.chromium.org/658013002/) Reason for revert: Linux Chromium OS ASan LSan Tests (1) http://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20(1) started burning when this landed: @@@STEP_LOG_LINE@OnFileChanged@Direct leak of 48 byte(s) in 3 object(s) allocated from:@@@ @@@STEP_LOG_LINE@OnFileChanged@ #0 0x579f3b in operator new(unsigned long) (/tmp/run_tha_testfLYqpC/out/Release/browser_tests+0x579f3b)@@@ @@@STEP_LOG_LINE@OnFileChanged@ #1 0x4a85629 in file_manager::(anonymous namespace)::CreateAndStartFilePathWatcher(base::FilePath const&, base::Callback\u003Cvoid (base::FilePath const&, bool)> const&) chrome/browser/chromeos/file_manager/file_watcher.cc:24:3@@@ Original issue's description: > Changed api to notify when watched directory is deleted. > > BUG=423257 > TEST=out/Release/browser_tests --gtest_filter=FileManagerPrivateApiTest.OnFileChanged > > Committed: https://crrev.com/962dea43ddd90e7e4224a03fa3c36a421281abb7 > Cr-Commit-Position: refs/heads/master@{#301325} TBR=mtomasz@chromium.org,yoshiki@chromium.org,yawano@chromium.org NOTREECHECKS=true NOTRY=true BUG=423257 Committed: https://crrev.com/c9205ddc2489bd76aa4bdbdbc30bd38ab1b74e28 Cr-Commit-Position: refs/heads/master@{#301373}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -185 lines) Patch
M chrome/browser/chromeos/drive/file_change.cc View 1 chunk +4 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/event_router.h View 5 chunks +0 lines, -22 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/event_router.cc View 4 chunks +9 lines, -70 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/file_manager_private_apitest.cc View 5 chunks +1 line, -88 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Avi (use Gerrit)
Created Revert of Changed api to notify when watched directory is deleted.
6 years, 1 month ago (2014-10-27 16:03:56 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/676403003/1
6 years, 1 month ago (2014-10-27 16:05:41 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-10-27 16:07:02 UTC) #3
commit-bot: I haz the power
6 years, 1 month ago (2014-10-27 16:07:39 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c9205ddc2489bd76aa4bdbdbc30bd38ab1b74e28
Cr-Commit-Position: refs/heads/master@{#301373}

Powered by Google App Engine
This is Rietveld 408576698