Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issue 676403002: Sync wallpaper based on sync themes setting (Closed)

Created:
6 years, 1 month ago by Ran
Modified:
6 years, 1 month ago
Reviewers:
bshe
CC:
chromium-reviews, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, asvitkine+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Reland issue 671513010 check sync themes setting patch. Seems the revert is a false alarm so reland the original patch. refer to https://codereview.chromium.org/682463002/ BUG=236640 TBR=scheib@chromium.org,cpu@chromium.org,jar@chromium.org,bshe@chromium.org Committed: https://crrev.com/4289d3a25b4a21c8ea3c1dd2cf08c8c94e344001 Cr-Commit-Position: refs/heads/master@{#301415}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+153 lines, -78 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +10 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/extensions/wallpaper_private_api.h View 1 chunk +13 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/extensions/wallpaper_private_api.cc View 2 chunks +13 lines, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/wallpaper_manager/js/event_page.js View 1 chunk +68 lines, -64 lines 0 comments Download
M chrome/browser/resources/chromeos/wallpaper_manager/js/util.js View 5 chunks +25 lines, -11 lines 0 comments Download
M chrome/common/extensions/api/wallpaper_private.json View 1 chunk +19 lines, -0 lines 0 comments Download
M chrome/test/data/chromeos/wallpaper_manager/unit_tests/api_mock.js View 1 chunk +3 lines, -0 lines 0 comments Download
M extensions/browser/extension_function_histogram_value.h View 1 chunk +1 line, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 21 (9 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/676403002/1
6 years, 1 month ago (2014-10-27 15:02:06 UTC) #2
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 1 month ago (2014-10-27 15:02:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/676403002/1
6 years, 1 month ago (2014-10-27 15:11:46 UTC) #6
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 1 month ago (2014-10-27 15:11:49 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/676403002/1
6 years, 1 month ago (2014-10-27 15:18:30 UTC) #10
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 1 month ago (2014-10-27 15:18:34 UTC) #12
bshe
On 2014/10/27 15:18:34, I haz the power (commit-bot) wrote: > No LGTM from a valid ...
6 years, 1 month ago (2014-10-27 15:24:14 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/676403002/1
6 years, 1 month ago (2014-10-27 15:24:59 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel/builds/3407)
6 years, 1 month ago (2014-10-27 16:29:40 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/676403002/1
6 years, 1 month ago (2014-10-27 17:57:36 UTC) #19
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-10-27 19:35:52 UTC) #20
commit-bot: I haz the power
6 years, 1 month ago (2014-10-27 19:36:56 UTC) #21
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4289d3a25b4a21c8ea3c1dd2cf08c8c94e344001
Cr-Commit-Position: refs/heads/master@{#301415}

Powered by Google App Engine
This is Rietveld 408576698