Issue 6764013: Fix Windows 64-bit build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6764013: Fix Windows 64-bit build. (Closed)

Created:
9 years, 8 months ago by William Hesse

Modified:
9 years, 7 months ago

Reviewers:
Vitaly Repeshko

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Fix Windows 64-bit build. BUG= TEST=

Patch Set 1 #

Total comments: 1

Patch Set 2 : oops #

Patch Set 3 : ooph #

Created: 9 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -4 lines)			Patch
	M	src/x64/assembler-x64.cc	View	1	3 chunks	+5 lines, -3 lines	0 comments	Download
	M	src/x64/codegen-x64.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

William Hesse

Do we have an Isolate at the point that we call this? I though we ...

9 years, 8 months ago (2011-04-01 11:12:12 UTC) #1

Vitaly Repeshko

9 years, 8 months ago (2011-04-01 11:16:14 UTC) #2

LGTM

http://codereview.chromium.org/6764013/diff/1/src/x64/codegen-x64.cc
File src/x64/codegen-x64.cc (right):

http://codereview.chromium.org/6764013/diff/1/src/x64/codegen-x64.cc#newcode8758
src/x64/codegen-x64.cc:8758: Assembler masm(Isolate::Current(), buffer,
static_cast<int>(actual_size));
Please try passing NULL instead. The assembler should not depend on the isolate
when given a buffer. If it still does, let's fixit it.

Expand Messages | Collapse Messages