Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 676393003: Revert of DevTools: [CodeMirrro] defer autocomplete controller initialization (Closed)

Created:
6 years, 1 month ago by vsevik
Modified:
6 years, 1 month ago
Reviewers:
lushnikov
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Revert of DevTools: [CodeMirrro] defer autocomplete controller initialization (patchset #2 id:20001 of https://codereview.chromium.org/670163002/) Reason for revert: Breaks autocomplete (only ctrl+space works) Original issue's description: > DevTools: [CodeMirrro] defer autocomplete controller initialization > > Autocompletion controller intialization makes almost half of the time > of SourceFrame initialization. > > In order to render editor as fast as possible, this patch defers > autocompletion initialization until the first need. > > BUG=425550 > R=vsevik > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184263 TBR=lushnikov@chromium.org NOTREECHECKS=true NOTRY=true BUG=425550 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184451

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -18 lines) Patch
M LayoutTests/inspector/editor/text-editor-autocomplete.html View 1 chunk +0 lines, -1 line 0 comments Download
M Source/devtools/front_end/source_frame/CodeMirrorTextEditor.js View 3 chunks +6 lines, -17 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
vsevik
Created Revert of DevTools: [CodeMirrro] defer autocomplete controller initialization
6 years, 1 month ago (2014-10-27 14:44:33 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/676393003/1
6 years, 1 month ago (2014-10-27 14:45:05 UTC) #2
commit-bot: I haz the power
6 years, 1 month ago (2014-10-27 14:45:48 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 184451

Powered by Google App Engine
This is Rietveld 408576698