Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 67633002: Exit metro mode without leaving a ghost (Closed)

Created:
7 years, 1 month ago by cpu_(ooo_6.6-7.5)
Modified:
7 years, 1 month ago
Reviewers:
Shrikant Kelkar, ananta
CC:
chromium-reviews
Visibility:
Public.

Description

Exit metro mode without leaving a ghost This basically brings the code we have for m28 chrome that uses alt-f4 trick to kill the metro viewer without leaving the strange thumbnail window in the desktop left corner. BUG=315919 TEST=see bug Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=234113

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -5 lines) Patch
win8/metro_driver/chrome_app_view_ash.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
win8/metro_driver/chrome_app_view_ash.cc View 1 2 3 chunks +82 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
cpu_(ooo_6.6-7.5)
please take a look.
7 years, 1 month ago (2013-11-09 02:08:41 UTC) #1
cpu_(ooo_6.6-7.5)
.
7 years, 1 month ago (2013-11-09 02:51:44 UTC) #2
ananta
lgtm https://codereview.chromium.org/67633002/diff/40001/win8/metro_driver/chrome_app_view_ash.h File win8/metro_driver/chrome_app_view_ash.h (right): https://codereview.chromium.org/67633002/diff/40001/win8/metro_driver/chrome_app_view_ash.h#newcode85 win8/metro_driver/chrome_app_view_ash.h:85: HWND core_window() const { return core_window_hwnd_; } Please ...
7 years, 1 month ago (2013-11-09 02:59:23 UTC) #3
cpu_(ooo_6.6-7.5)
https://codereview.chromium.org/67633002/diff/40001/win8/metro_driver/chrome_app_view_ash.h File win8/metro_driver/chrome_app_view_ash.h (right): https://codereview.chromium.org/67633002/diff/40001/win8/metro_driver/chrome_app_view_ash.h#newcode85 win8/metro_driver/chrome_app_view_ash.h:85: HWND core_window() const { return core_window_hwnd_; } On 2013/11/09 ...
7 years, 1 month ago (2013-11-09 03:08:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cpu@chromium.org/67633002/270001
7 years, 1 month ago (2013-11-09 03:08:38 UTC) #5
commit-bot: I haz the power
7 years, 1 month ago (2013-11-09 05:26:53 UTC) #6
Message was sent while issue was closed.
Change committed as 234113

Powered by Google App Engine
This is Rietveld 408576698