Non-SFI mode: Add --use-nacl-helper-nonsfi flag.

components/nacl/common/nacl_paths.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/nacl/common/nacl_paths.h"
 
+#include "base/command_line.h"
 #include "base/files/file_util.h"
 #include "base/path_service.h"
+#include "components/nacl/common/nacl_switches.h"
 
 namespace {
 
-#if defined(OS_POSIX) && !defined(OS_MACOSX)
+#if defined(OS_LINUX)
 // File name of the nacl_helper and nacl_helper_bootstrap, Linux only.
 const base::FilePath::CharType kInternalNaClHelperFileName[] =
     FILE_PATH_LITERAL("nacl_helper");
+const base::FilePath::CharType kInternalNaClHelperNonSfiFileName[] =
+    FILE_PATH_LITERAL("nacl_helper_nonsfi");
 const base::FilePath::CharType kInternalNaClHelperBootstrapFileName[] =
     FILE_PATH_LITERAL("nacl_helper_bootstrap");
+
+bool GetNaClHelperPath(const base::FilePath::CharType* filename,
+                       base::FilePath* output) {
+  if (!PathService::Get(base::DIR_MODULE, output))
+    return false;
+  *output = output->Append(filename);

[Junichi Uekawa, 2014/10/30 11:04:19]

This blew my mind, I see operator= is overloaded so this probably works but I
felt really uncomfortable.

[hidehiko, 2014/10/30 11:08:40]

FilePath::Append() is const method, i.e. does not change the object contents,
but returns a new file path which is the {original_path}/{filename}.
So, this is the way to append |filename| to |output|.

+  return true;
+}
+
 #endif
 
 }  // namespace
 
 namespace nacl {
 
 bool PathProvider(int key, base::FilePath* result) {
-  base::FilePath cur;
   switch (key) {
 #if defined(OS_LINUX)
     case FILE_NACL_HELPER:
-      if (!PathService::Get(base::DIR_MODULE, &cur))
-        return false;
-      cur = cur.Append(kInternalNaClHelperFileName);
-      break;
+      return GetNaClHelperPath(kInternalNaClHelperFileName, result);
+    case FILE_NACL_HELPER_NONSFI:
+      if (!base::CommandLine::ForCurrentProcess()->HasSwitch(
+              switches::kUseNaClHelperNonSfi)) {
+        // Currently nacl_helper_nonsfi is disabled, so use nacl_helper
+        // in Non-SFI mode instead.
+        // TODO(hidehiko): Remove this code path after nacl_helper_nonsfi
+        // is supported.
+        return GetNaClHelperPath(kInternalNaClHelperFileName, result);
+      }
+      return GetNaClHelperPath(kInternalNaClHelperNonSfiFileName, result);
     case FILE_NACL_HELPER_BOOTSTRAP:
-      if (!PathService::Get(base::DIR_MODULE, &cur))
-        return false;
-      cur = cur.Append(kInternalNaClHelperBootstrapFileName);
-      break;
+      return GetNaClHelperPath(kInternalNaClHelperBootstrapFileName, result);
 #endif
     default:
       return false;
   }
-
-  *result = cur;
-  return true;
 }
 
 // This cannot be done as a static initializer sadly since Visual Studio will
 // eliminate this object file if there is no direct entry point into it.
 void RegisterPathProvider() {
   PathService::RegisterProvider(PathProvider, PATH_START, PATH_END);
 }
 
 }  // namespace nacl