Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 676293002: Avoid inserting duplicated entries after creating a directory. (Closed)

Created:
6 years, 1 month ago by fukino
Modified:
6 years, 1 month ago
Reviewers:
yoshiki
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org, yoshiki+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Avoid inserting duplicated entries after creating a directory. New entries which are passed to DirectoryContents.onNewEntries_ are determined in DorectoryContents.update, but before they are inserted in the file list, the file list may change. When creating a new directory in Drive, this sometimes occurs. This CL adds duplication check just before inserting entries. BUG=423646 TEST=creating a directory in MyDrive By Ctrl-E and check if there's no duplicated folder. Committed: https://crrev.com/2a724e66aff9c867195b21fd774fa563e315e1e2 Cr-Commit-Position: refs/heads/master@{#301335}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M ui/file_manager/file_manager/foreground/js/directory_contents.js View 1 chunk +8 lines, -0 lines 1 comment Download

Messages

Total messages: 8 (2 generated)
fukino
yoshiki@, could you take a look? Thanks! https://codereview.chromium.org/676293002/diff/1/ui/file_manager/file_manager/foreground/js/directory_contents.js File ui/file_manager/file_manager/foreground/js/directory_contents.js (right): https://codereview.chromium.org/676293002/diff/1/ui/file_manager/file_manager/foreground/js/directory_contents.js#newcode831 ui/file_manager/file_manager/foreground/js/directory_contents.js:831: currentURLs[this.fileList_.item(i).toURL()] = ...
6 years, 1 month ago (2014-10-27 05:09:49 UTC) #2
yoshiki
lgtm
6 years, 1 month ago (2014-10-27 08:53:17 UTC) #3
fukino
On 2014/10/27 08:53:17, yoshiki wrote: > lgtm Thanks!
6 years, 1 month ago (2014-10-27 09:22:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/676293002/1
6 years, 1 month ago (2014-10-27 09:23:48 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-10-27 10:09:29 UTC) #7
commit-bot: I haz the power
6 years, 1 month ago (2014-10-27 10:10:11 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2a724e66aff9c867195b21fd774fa563e315e1e2
Cr-Commit-Position: refs/heads/master@{#301335}

Powered by Google App Engine
This is Rietveld 408576698