LayoutTests/inspector/console/console-search-can-jump-forward-between-matches.html - Issue 676193002: Navigate between individual search matches in DevTools console

Unified Diff: LayoutTests/inspector/console/console-search-can-jump-forward-between-matches.html

Issue 676193002: Navigate between individual search matches in DevTools console (Closed) Base URL: https://chromium.googlesource.com/chromium/blink@master

Patch Set: Add tests Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/inspector/console/console-search-can-jump-backward-between-matches.html ('K') | « LayoutTests/inspector/console/console-search-can-jump-backward-between-matches-expected.txt ('k') | LayoutTests/inspector/console/console-search-can-jump-forward-between-matches-expected.txt » ('j') | Source/devtools/front_end/console/ConsoleView.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/inspector/console/console-search-can-jump-forward-between-matches.html

diff --git a/LayoutTests/inspector/console/console-search-reveals-messages.html b/LayoutTests/inspector/console/console-search-can-jump-forward-between-matches.html

similarity index 50%

copy from LayoutTests/inspector/console/console-search-reveals-messages.html

copy to LayoutTests/inspector/console/console-search-can-jump-forward-between-matches.html

index f057e77abf12888cc045da1306fac44be02e2baa..38ca285d3383b51eb723d45bbc697ad0d2f8172c 100644

--- a/LayoutTests/inspector/console/console-search-reveals-messages.html

+++ b/LayoutTests/inspector/console/console-search-can-jump-forward-between-matches.html

@@ -5,24 +5,36 @@

function populateConsoleWithMessages()

{

+ console.log("FIRST MATCH, SECOND MATCH");

for (var i = 0; i < 200; ++i)

console.log("Message #" + i);

- console.log("LAST MESSAGE");

+ console.log("LAST MATCH");

runTest();

}

function test()

{

+ function addResult(result)

+ {

+ viewport.refresh();

+ InspectorTest.addResult(result);

+ }

+ // Make sure to produce test output in case test times out

+ setTimeout(InspectorTest.completeTest.bind(InspectorTest), 2000);

var consoleView = WebInspector.ConsolePanel._view();

var viewport = consoleView._viewport;

const maximumViewportMessagesCount = 150;

InspectorTest.runTestSuite([

- function verifyViewportIsTallEnough(next)

+ function assertViewportHeight(next)

{

viewport.invalidate();

var viewportMessagesCount = viewport._lastVisibleIndex - viewport._firstVisibleIndex;

if (viewportMessagesCount > maximumViewportMessagesCount) {

- InspectorTest.addResult(String.sprintf("Test cannot be run because viewport could fit %d messages which is more then maxiumum of %d.", viewportMessagesCount, maximumViewportMessagesCount));

+ InspectorTest.addResult(String.sprintf(

+ "Test cannot be run because viewport can fit %d messages, while %d is the test's maximum.",

+ viewportMessagesCount, maximumViewportMessagesCount));

InspectorTest.completeTest();

return;

}

@@ -32,37 +44,35 @@ function test()

function scrollConsoleToTop(next)

{

viewport.forceScrollItemToBeFirst(0);

- dumpTop();

+ addResult("first visible message index: " + viewport.firstVisibleIndex());

next();

- function testFindLastMessage(next)

+ function testFindMatches(next)

{

- consoleView._searchableView._searchInputElement.value = "LAST MESSAGE";

+ consoleView._searchableView._searchInputElement.value = "MATCH";

consoleView._searchableView.showSearchField();

+ // Find first match

+ consoleView._searchableView.handleFindNextShortcut();

+ addResult("first visible message index: " + viewport.firstVisibleIndex());

+ // Find second match

+ consoleView._searchableView.handleFindNextShortcut();

+ addResult("first visible message index: " + viewport.firstVisibleIndex());

+ // Find last match

consoleView._searchableView.handleFindNextShortcut();

- dumpBottom();

+ addResult("last visible message index: " + viewport.lastVisibleIndex());

next();

}

]);

- function dumpTop()

- {

- viewport.refresh();

- InspectorTest.addResult("first visible message index: " + viewport.firstVisibleIndex());

- }

- function dumpBottom()

- {

- viewport.refresh();

- InspectorTest.addResult("last visible message index: " + viewport.lastVisibleIndex());

- }

}

</script>

</head>

<p>

- Tests that console viewport reveals messages on searching.

+ Tests that console can jump forward between search matches when clicking the find next button.

</p>

</body>

</html>