Navigate between individual search matches in DevTools console

Source/devtools/front_end/console/ConsoleViewMessage.js

 /*
  * Copyright (C) 2011 Google Inc.  All rights reserved.
  * Copyright (C) 2007, 2008 Apple Inc.  All rights reserved.
  * Copyright (C) 2009 Joseph Pecoraro
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
@@ skipping 919 matching lines @@
                 }
                 a.appendChild(toAppend);
             }
             return a;
         }
 
         // String.format does treat formattedResult like a Builder, result is an object.
         return String.format(format, parameters, formatters, formattedResult, append);
     },
 
-    clearHighlight: function()
+    clearHighlights: function()
     {
         if (!this._formattedMessage)
             return;
 
         WebInspector.removeSearchResultsHighlight(this._formattedMessage);
     },
 
+    // XXX: Can we remove this?

[lushnikov, 2014/11/07 16:27:19]

yes!

[aknudsen, 2014/11/09 00:02:13]

Done.

     highlightSearchResults: function(regexObject)
     {
         if (!this._formattedMessage)
             return;
 
         this._highlightSearchResultsInElement(regexObject, this._messageElement);
         if (this._anchorElement)
             this._highlightSearchResultsInElement(regexObject, this._anchorElement);
     },
 
@@ skipping 301 matching lines @@
                 break;
         }
 
         return sourceString + " " + typeString + " " + levelString + ": " + this.formattedMessage().textContent + "\n" + this._message.url + " line " + this._message.line;
     },
 
     get text()
     {
         return this._message.messageText;
     },
+
+    /**
+    * @return {!string}

[lushnikov, 2014/11/07 16:27:19]

no need for an exclamation mark - string is non-nullable as it's written with a
small letter in the beginning

[aknudsen, 2014/11/08 12:00:52]

Acknowledged.

[aknudsen, 2014/11/09 00:02:14]

Done.

+    */

[lushnikov, 2014/11/07 16:27:17]

wrong comment alining regarding asterisks

[aknudsen, 2014/11/08 12:00:52]

Acknowledged.

[aknudsen, 2014/11/09 00:02:13]

Done.

+    getText: function () {

[lushnikov, 2014/11/07 16:27:19]

brace on a new line

[aknudsen, 2014/11/08 12:00:52]

Acknowledged.

[aknudsen, 2014/11/09 00:02:13]

Done.

+        if (!this._messageElement)
+            return '';

[lushnikov, 2014/11/07 16:27:19]

we use only double-quotes for strings

[aknudsen, 2014/11/08 12:00:52]

Acknowledged.

[aknudsen, 2014/11/09 00:02:13]

Done.

+        return this._messageElement.textContent;
+    },
+
+    /**
+    * @return {!Array.<!Element>}

[lushnikov, 2014/11/07 16:27:19]

comment aligning + annotation for arguments

[aknudsen, 2014/11/08 12:00:52]

Acknowledged.

[aknudsen, 2014/11/09 00:02:13]

Done.

+    */
+    highlightMatch: function(start, end)
+    {
+        var highlightNodes = [];
+        if (this._formattedMessage)
+            highlightNodes = WebInspector.highlightSearchResults(this._messageElement,

[lushnikov, 2014/11/07 16:27:19]

no wrap

[aknudsen, 2014/11/08 12:00:52]

Acknowledged.

[aknudsen, 2014/11/09 00:02:13]

Done.

+                [new WebInspector.SourceRange(start, end - start + 1)]);
+        return highlightNodes;
+    },

[lushnikov, 2014/11/07 16:27:19]

no trailing comma

[aknudsen, 2014/11/08 12:00:52]

Acknowledged.

[aknudsen, 2014/11/09 00:02:13]

Done.

 }
 
 /**
  * @constructor
  * @extends {WebInspector.ConsoleViewMessage}
  * @param {!WebInspector.ConsoleMessage} consoleMessage
  * @param {!WebInspector.Linkifier} linkifier
  * @param {number} nestingLevel
  */
 WebInspector.ConsoleGroupViewMessage = function(consoleMessage, linkifier, nestingLevel)
@@ skipping 29 matching lines @@
     {
         if (!this._wrapperElement) {
             WebInspector.ConsoleViewMessage.prototype.toMessageElement.call(this);
             this._wrapperElement.classList.toggle("collapsed", this._collapsed);
         }
         return this._wrapperElement;
     },
 
     __proto__: WebInspector.ConsoleViewMessage.prototype
 }