LayoutTests/inspector/console/console-search-can-highlight-current-match.html - Issue 676193002: Navigate between individual search matches in DevTools console

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/inspector/console/console-search-can-highlight-current-match.html

Issue 676193002: Navigate between individual search matches in DevTools console (Closed) Base URL: https://chromium.googlesource.com/chromium/blink@master

Patch Set: Add tests Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | LayoutTests/inspector/console/console-search-can-highlight-current-match-expected.txt » ('j') | LayoutTests/inspector/console/console-search-can-jump-backward-between-matches.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <html>

	2 <head>

	3 <script src="../../http/tests/inspector/inspector-test.js"></script>

	4 <script src="../../http/tests/inspector/console-test.js"></script>

	5 <script>

	6 function populateConsoleWithMessages()

	7 {

	8 console.log("FIRST MATCH");

	9 console.log("SECOND MATCH");

	10 runTest();

	11 }

	12

	13 function test()

	14 {

	15 function addResult(result)

	16 {

	17 viewport.refresh();

	18 InspectorTest.addResult(result);

	19 }

	20

	21 // Make sure to produce test output in case test times out

	22 setTimeout(InspectorTest.completeTest.bind(InspectorTest), 2000);
	lushnikov 2014/11/07 16:27:16 We do not commit these lines - just use them to de We do not commit these lines - just use them to debug. Please, remove aknudsen 2014/11/08 12:00:52 Ah OK. Show quoted text On 2014/11/07 16:27:16, lushnikov wrote: > We do not commit these lines - just use them to debug. Please, remove Ah OK. aknudsen 2014/11/09 00:02:12 Done. Show quoted text On 2014/11/07 16:27:16, lushnikov wrote: > We do not commit these lines - just use them to debug. Please, remove Done.
	23

	24 var consoleView = WebInspector.ConsolePanel._view();

	25 var viewport = consoleView._viewport;

	26 InspectorTest.runTestSuite([

	27 function scrollConsoleToTop(next)

	28 {

	29 viewport.forceScrollItemToBeFirst(0);

	30 addResult("first visible message index: " + viewport.firstVisibleInd ex());

	31 next();

	32 },

	33

	34 function testMarkCurrentMatch(next)

	35 {

	36 consoleView._searchableView._searchInputElement.value = "MATCH";

	37 consoleView._searchableView.showSearchField();

	38

	39 // Find first match

	40 consoleView._searchableView.handleFindNextShortcut();

	41 addResult(InspectorTest.dumpConsoleMessagesIntoArray(false, true));

	42

	43 // Find second match

	44 consoleView._searchableView.handleFindNextShortcut();

	45 addResult(InspectorTest.dumpConsoleMessagesIntoArray(false, true));

	46 }
	lushnikov 2014/11/07 16:27:16 you don't call "next()" in the end of the function you don't call "next()" in the end of the function. aknudsen 2014/11/08 12:00:52 Acknowledged. Show quoted text On 2014/11/07 16:27:16, lushnikov wrote: > you don't call "next()" in the end of the function. Acknowledged. aknudsen 2014/11/09 00:02:12 Done. Show quoted text On 2014/11/07 16:27:16, lushnikov wrote: > you don't call "next()" in the end of the function. Done.
	47 ]);

	48 }

	49 </script>

	50 </head>

	51 <body onload="populateConsoleWithMessages()">

	52 <p>

	53 Tests that console can highlight the current search match.

	54 </p>

	55 </body>

	56 </html>

OLD	NEW