Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(806)

Issue 676183002: Oilpan: simplify quota storage callbacks objects. (Closed)

Created:
6 years, 1 month ago by sof
Modified:
6 years, 1 month ago
CC:
blink-reviews, dglazkov+blink, kinuko+fileapi, nhiroki, tzik
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Oilpan: simplify quota storage callbacks objects. With callback objects now being on the heap by default, we can simplify the objects wrapping storage callbacks. R=haraken BUG=340522 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184420

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -62 lines) Patch
M Source/modules/quota/DeprecatedStorageQuota.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/quota/DeprecatedStorageQuotaCallbacksImpl.h View 2 chunks +7 lines, -7 lines 0 comments Download
M Source/modules/quota/StorageQuota.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/quota/StorageQuotaCallbacksImpl.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/platform/StorageQuotaCallbacks.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/exported/WebStorageQuotaCallbacks.cpp View 2 chunks +5 lines, -31 lines 0 comments Download
M Source/web/StorageQuotaClientImpl.h View 1 chunk +4 lines, -1 line 0 comments Download
M Source/web/StorageQuotaClientImpl.cpp View 4 chunks +5 lines, -10 lines 0 comments Download
M public/platform/WebStorageQuotaCallbacks.h View 3 chunks +2 lines, -5 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
sof
Please take a look. Given that quota/ ships with Oilpan, it makes sense to reduce ...
6 years, 1 month ago (2014-10-25 15:24:08 UTC) #2
haraken
LGTM
6 years, 1 month ago (2014-10-26 15:22:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/676183002/1
6 years, 1 month ago (2014-10-26 18:35:15 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: blink_presubmit on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/18380)
6 years, 1 month ago (2014-10-26 18:40:24 UTC) #7
sof
On 2014/10/26 18:40:24, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
6 years, 1 month ago (2014-10-26 23:13:30 UTC) #8
tkent
lgtm
6 years, 1 month ago (2014-10-27 02:01:07 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/676183002/1
6 years, 1 month ago (2014-10-27 02:02:01 UTC) #12
commit-bot: I haz the power
6 years, 1 month ago (2014-10-27 02:06:00 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 184420

Powered by Google App Engine
This is Rietveld 408576698