Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2567)

Unified Diff: sky/engine/core/html/parser/HTMLTreeBuilder.cpp

Issue 676133002: Remove HTMLParserOptions (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Fixup Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/engine/core/html/parser/HTMLTreeBuilder.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/core/html/parser/HTMLTreeBuilder.cpp
diff --git a/sky/engine/core/html/parser/HTMLTreeBuilder.cpp b/sky/engine/core/html/parser/HTMLTreeBuilder.cpp
index 1484c82a593b3c3a4ac56beda2f4906b253fdafa..56be56d56386cbdb500ecb4cae4aea9336d9b3d5 100644
--- a/sky/engine/core/html/parser/HTMLTreeBuilder.cpp
+++ b/sky/engine/core/html/parser/HTMLTreeBuilder.cpp
@@ -45,7 +45,7 @@ static TextPosition uninitializedPositionValue1()
return TextPosition(OrdinalNumber::fromOneBasedInt(-1), OrdinalNumber::first());
}
-HTMLTreeBuilder::HTMLTreeBuilder(HTMLDocumentParser* parser, HTMLDocument* document, bool, const HTMLParserOptions& options)
+HTMLTreeBuilder::HTMLTreeBuilder(HTMLDocumentParser* parser, HTMLDocument* document, bool)
:
#if ENABLE(ASSERT)
m_isAttached(true),
@@ -55,48 +55,14 @@ HTMLTreeBuilder::HTMLTreeBuilder(HTMLDocumentParser* parser, HTMLDocument* docum
, m_originalInsertionMode(HTMLMode)
, m_parser(parser)
, m_scriptToProcessStartPosition(uninitializedPositionValue1())
- , m_options(options)
{
m_tree.openElements()->pushRootNode(document);
}
-// FIXME: Member variables should be grouped into self-initializing structs to
-// minimize code duplication between these constructors.
-HTMLTreeBuilder::HTMLTreeBuilder(HTMLDocumentParser* parser, DocumentFragment* fragment, Element* contextElement, const HTMLParserOptions& options)
- :
-#if ENABLE(ASSERT)
- m_isAttached(true),
-#endif
- m_fragmentContext(fragment, contextElement)
- , m_tree(fragment)
- , m_insertionMode(HTMLMode)
- , m_originalInsertionMode(HTMLMode)
- , m_parser(parser)
- , m_scriptToProcessStartPosition(uninitializedPositionValue1())
- , m_options(options)
-{
- ASSERT(isMainThread());
- ASSERT(contextElement);
-
- // Steps 4.2-4.6 of the HTML5 Fragment Case parsing algorithm:
- // http://www.whatwg.org/specs/web-apps/current-work/multipage/the-end.html#fragment-case
- // For efficiency, we skip step 4.2 ("Let root be a new html element with no attributes")
- // and instead use the DocumentFragment as a root node.
- m_tree.openElements()->pushRootNode(fragment);
-}
-
HTMLTreeBuilder::~HTMLTreeBuilder()
{
}
-void HTMLTreeBuilder::trace(Visitor* visitor)
-{
- visitor->trace(m_fragmentContext);
- visitor->trace(m_tree);
- visitor->trace(m_parser);
- visitor->trace(m_scriptToProcess);
-}
-
void HTMLTreeBuilder::detach()
{
#if ENABLE(ASSERT)
« no previous file with comments | « sky/engine/core/html/parser/HTMLTreeBuilder.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698