Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 676133002: Remove HTMLParserOptions (Closed)

Created:
6 years, 2 months ago by abarth-chromium
Modified:
6 years, 2 months ago
Reviewers:
esprehn, eseidel
CC:
mojo-reviews_chromium.org, ojan, esprehn
Base URL:
https://github.com/domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Remove HTMLParserOptions We always use threading now and there aren't any other options. R=eseidel@chromium.org, esprehn@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/eacb125c868375f1066f964c93d39a07667541ba

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fixup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -302 lines) Patch
M sky/engine/core/core.gni View 1 2 chunks +0 lines, -4 lines 0 comments Download
D sky/engine/core/dom/DecodedDataDocumentParser.h View 1 1 chunk +0 lines, -43 lines 0 comments Download
D sky/engine/core/dom/DecodedDataDocumentParser.cpp View 1 1 chunk +0 lines, -43 lines 0 comments Download
M sky/engine/core/html/parser/BackgroundHTMLParser.h View 2 chunks +0 lines, -2 lines 0 comments Download
M sky/engine/core/html/parser/BackgroundHTMLParser.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/html/parser/HTMLDocumentParser.h View 1 4 chunks +3 lines, -11 lines 0 comments Download
M sky/engine/core/html/parser/HTMLDocumentParser.cpp View 1 5 chunks +2 lines, -13 lines 0 comments Download
D sky/engine/core/html/parser/HTMLParserOptions.h View 1 chunk +0 lines, -42 lines 0 comments Download
D sky/engine/core/html/parser/HTMLParserOptions.cpp View 1 chunk +0 lines, -41 lines 0 comments Download
M sky/engine/core/html/parser/HTMLTokenizer.h View 5 chunks +2 lines, -24 lines 0 comments Download
M sky/engine/core/html/parser/HTMLTokenizer.cpp View 2 chunks +1 line, -31 lines 0 comments Download
M sky/engine/core/html/parser/HTMLTreeBuilder.h View 4 chunks +3 lines, -12 lines 0 comments Download
M sky/engine/core/html/parser/HTMLTreeBuilder.cpp View 1 2 chunks +1 line, -35 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
abarth-chromium
6 years, 2 months ago (2014-10-25 05:04:08 UTC) #1
eseidel
lgtm https://codereview.chromium.org/676133002/diff/1/sky/engine/core/html/parser/HTMLTreeBuilder.cpp File sky/engine/core/html/parser/HTMLTreeBuilder.cpp (left): https://codereview.chromium.org/676133002/diff/1/sky/engine/core/html/parser/HTMLTreeBuilder.cpp#oldcode65 sky/engine/core/html/parser/HTMLTreeBuilder.cpp:65: HTMLTreeBuilder::HTMLTreeBuilder(HTMLDocumentParser* parser, DocumentFragment* fragment, Element* contextElement, const HTMLParserOptions& ...
6 years, 2 months ago (2014-10-25 05:08:38 UTC) #4
commit-bot: I haz the power
Commit queue rejected this change because it did not recognize the base URL. Please commit ...
6 years, 2 months ago (2014-10-25 05:11:54 UTC) #6
abarth-chromium
6 years, 2 months ago (2014-10-25 05:49:55 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
eacb125c868375f1066f964c93d39a07667541ba (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698