Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(988)

Issue 67613002: cc: Minor clean ups to ETC1PixelRef header. (Closed)

Created:
7 years, 1 month ago by tfarina
Modified:
7 years, 1 month ago
CC:
chromium-reviews, cc-bugs_chromium.org
Visibility:
Public.

Description

cc: Minor clean ups to ETC1PixelRef header. - remove unnecessary includes - use chromium OVERRIDE macro instead of skia SK_OVERRIDE. - use DISALLOW_COPY_AND_ASSIGN macro. BUG=None TEST=cc_unittests R=enne@chromium.org,jamesr@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=234110

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -6 lines) Patch
M cc/resources/etc1_pixel_ref.h View 2 chunks +7 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
tfarina
I was grepping for 'ownership' and happened to look at this header file. Please, take ...
7 years, 1 month ago (2013-11-09 01:07:43 UTC) #1
aelias_OOO_until_Jul13
OK, this was just added today in https://codereview.chromium.org/41903003/ and I missed these issues in my ...
7 years, 1 month ago (2013-11-09 02:28:16 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/67613002/1
7 years, 1 month ago (2013-11-09 02:30:30 UTC) #3
commit-bot: I haz the power
Change committed as 234110
7 years, 1 month ago (2013-11-09 05:14:35 UTC) #4
powei
7 years, 1 month ago (2013-11-09 08:01:15 UTC) #5
Message was sent while issue was closed.
On 2013/11/09 05:14:35, I haz the power (commit-bot) wrote:
> Change committed as 234110

Yes.  Sorry I missed these in the original patch.  Thank you for cleaning this
up.

Powered by Google App Engine
This is Rietveld 408576698