Add AddCallbackForCookie method to CookieStore.

Add AddCallbackForCookie method to CookieStore.

This method allows clients to register a callback to receive notification
whenever the set of cookies stored in a cookie store that would be sent for a
request to a specific URL changes.

BUG=395146
Committed: https://crrev.com/399e35a27ad10cb2f7337a1cbd37a104552f2352
Cr-Commit-Position: refs/heads/master@{#301339}

[erikwright (departed), 2014-10-24 20:11:09]

erikwright@chromium.org changed reviewers:
+ erikwright@chromium.org

[erikwright (departed), 2014-10-24 20:11:10]

LGTM with nits.

https://codereview.chromium.org/676073003/diff/1/chrome/browser/prerender/pre...
File chrome/browser/prerender/prerender_cookie_store.cc (right):

https://codereview.chromium.org/676073003/diff/1/chrome/browser/prerender/pre...
chrome/browser/prerender/prerender_cookie_store.cc:242: // TODO(ellyjones):
implement?
use "NOTIMPLEMENTED();" from base/logging.h so that we catch any unexpected
usage of this.

https://codereview.chromium.org/676073003/diff/1/net/cookies/cookie_monster.cc
File net/cookies/cookie_monster.cc (right):

https://codereview.chromium.org/676073003/diff/1/net/cookies/cookie_monster.c...
net/cookies/cookie_monster.cc:2327: hook_map_[key] = list;
hook_map_[key] = make_linked_ptr(new CookieChangedCallbackList());

Which probably allows you to drop the braces from this 'if' statement.

https://codereview.chromium.org/676073003/diff/1/net/cookies/cookie_monster.c...
net/cookies/cookie_monster.cc:2329: return hook_map_[key]->Add(wrapped);
I would inline the call to base::Bind here. No need for |wrapped| temp local
variable.

https://codereview.chromium.org/676073003/diff/1/net/cookies/cookie_store_tes...
File net/cookies/cookie_store_test_helpers.cc (right):

https://codereview.chromium.org/676073003/diff/1/net/cookies/cookie_store_tes...
net/cookies/cookie_store_test_helpers.cc:143: return
scoped_ptr<CookieStore::CookieChangedSubscription>();
ADD_FAILURE();

https://codereview.chromium.org/676073003/diff/1/net/websockets/websocket_job...
File net/websockets/websocket_job_test.cc (right):

https://codereview.chromium.org/676073003/diff/1/net/websockets/websocket_job...
net/websockets/websocket_job_test.cc:234: return
scoped_ptr<CookieChangedSubscription>();
ADD_FAILURE()

[Elly Fong-Jones, 2014-10-24 20:20:13]

The CQ bit was checked by ellyjones@chromium.org

[commit-bot: I haz the power, 2014-10-24 20:21:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/676073003/20001

[commit-bot: I haz the power, 2014-10-24 20:28:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-24 20:28:51]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Elly Fong-Jones, 2014-10-24 20:33:22]

The CQ bit was checked by ellyjones@chromium.org

[commit-bot: I haz the power, 2014-10-24 20:34:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/676073003/40001

[commit-bot: I haz the power, 2014-10-24 20:43:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-24 20:43:51]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[davidben, 2014-10-24 20:47:23]

davidben@chromium.org changed reviewers:
+ davidben@chromium.org

[davidben, 2014-10-24 20:47:24]

lgtm

[Elly Fong-Jones, 2014-10-24 20:48:10]

The CQ bit was checked by ellyjones@chromium.org

[commit-bot: I haz the power, 2014-10-24 20:50:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/676073003/40001

[Elly Fong-Jones, 2014-10-24 20:53:16]

The CQ bit was unchecked by ellyjones@chromium.org

[Elly Fong-Jones, 2014-10-24 20:53:16]

The CQ bit was checked by ellyjones@chromium.org

[Elly Fong-Jones, 2014-10-24 20:53:19]

The CQ bit was unchecked by ellyjones@chromium.org

[Elly Fong-Jones, 2014-10-24 20:56:25]

The CQ bit was checked by ellyjones@chromium.org

[Elly Fong-Jones, 2014-10-24 20:57:52]

The CQ bit was unchecked by ellyjones@chromium.org

[cbentzel, 2014-10-27 10:28:01]

The CQ bit was checked by cbentzel@chromium.org

[commit-bot: I haz the power, 2014-10-27 10:28:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/676073003/40001

[commit-bot: I haz the power, 2014-10-27 11:10:05]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2014-10-27 11:10:47]

Patchset 3 (id:??) landed as
https://crrev.com/399e35a27ad10cb2f7337a1cbd37a104552f2352
Cr-Commit-Position: refs/heads/master@{#301339}