Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(499)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 676053002: Update zero suggest flags to match experiments. (Closed)

Created:
6 years, 1 month ago by Maria
Modified:
6 years, 1 month ago
Reviewers:
Mark P
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Update zero suggest flags to match experiments. BUG=324043 Committed: https://crrev.com/ad3bfefc155ecfe5ab488fda7db4e15f05397818 Cr-Commit-Position: refs/heads/master@{#301469}

Patch Set 1 #

Patch Set 2 : Update histograms file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -34 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +2 lines, -8 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 chunk +2 lines, -6 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/common/chrome_switches.cc View 1 chunk +4 lines, -14 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 4 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 19 (8 generated)
Maria
Updating about:flags switches to reflect the new options we want to test.
6 years, 1 month ago (2014-10-24 18:24:04 UTC) #2
Mark P
lgtm
6 years, 1 month ago (2014-10-24 19:28:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/676053002/1
6 years, 1 month ago (2014-10-24 19:50:09 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel/builds/2923)
6 years, 1 month ago (2014-10-24 20:22:00 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/676053002/1
6 years, 1 month ago (2014-10-24 20:25:24 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_tests_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tests_recipe/builds/21860)
6 years, 1 month ago (2014-10-24 21:38:30 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/676053002/20001
6 years, 1 month ago (2014-10-27 20:30:06 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel/builds/3610)
6 years, 1 month ago (2014-10-27 21:21:15 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/676053002/20001
6 years, 1 month ago (2014-10-27 21:31:39 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 1 month ago (2014-10-27 22:57:55 UTC) #18
commit-bot: I haz the power
6 years, 1 month ago (2014-10-27 22:58:45 UTC) #19
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/ad3bfefc155ecfe5ab488fda7db4e15f05397818
Cr-Commit-Position: refs/heads/master@{#301469}

Powered by Google App Engine
This is Rietveld 408576698