Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Issue 676043003: Don't initialize Ozone platform if running unit tests with OSMesa (Closed)

Created:
6 years, 1 month ago by GusFernandez
Modified:
6 years, 1 month ago
Reviewers:
lcwu1, spang
CC:
chromium-reviews, kalyank, ozone-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Don't initialize Ozone platform if running unit tests with OSMesa If Unit tests are compiled with Ozone enabled by default, the Ozone platform may be initialized twice leading to CHECK failures. BUG=427299 Committed: https://crrev.com/b1dfa83e1c9e953b6e0115d27946bf186cc26619 Cr-Commit-Position: refs/heads/master@{#301427}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M ui/gl/gl_implementation_ozone.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
GusFernandez
6 years, 1 month ago (2014-10-26 19:40:38 UTC) #2
spang
lgtm
6 years, 1 month ago (2014-10-27 14:59:23 UTC) #3
lcwu1
lgtm
6 years, 1 month ago (2014-10-27 18:45:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/676043003/1
6 years, 1 month ago (2014-10-27 19:21:00 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-10-27 20:09:01 UTC) #7
commit-bot: I haz the power
6 years, 1 month ago (2014-10-27 20:09:42 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b1dfa83e1c9e953b6e0115d27946bf186cc26619
Cr-Commit-Position: refs/heads/master@{#301427}

Powered by Google App Engine
This is Rietveld 408576698